Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚇🩹 Fix pinned min pydantic lower than min required package version #299

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Sep 20, 2024

This change fixes the failing test-min-versions workflow.
The workflow fails because installing the package requires pydantic>=2.7 where as the pinned min dependencies use pydantic==2.4.0, leading to an upgrade to a current pydantic (>=2.9) leading to a failing test due to a change in the json schema.

Change summary

  • 🚇🩹 Fix pinned min pydantic lower than min required package version
  • 🧹 Sort pinned min version in the same order package requirements

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

🧹 Sort pinned min version in the same order package requirements
@s-weigand s-weigand requested a review from a team as a code owner September 20, 2024 21:49
Copy link
Contributor

sourcery-ai bot commented Sep 20, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran-extras/fix-pydantic-minversion

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.26%. Comparing base (ae84a0c) to head (794a652).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #299   +/-   ##
=======================================
  Coverage   58.26%   58.26%           
=======================================
  Files          31       31           
  Lines        1598     1598           
  Branches      290      290           
=======================================
  Hits          931      931           
  Misses        651      651           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant