-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 3.0.0 #255
Comments
@joaander - we (MDAnalysis) started picking up the 3.0 release on our CI and we're coincidentally seeing a lot of weird coverage failures: https://dev.azure.com/mdanalysis/mdanalysis/_build/results?buildId=5846&view=logs&j=7a9c7d2c-346e-591b-84bb-5490fd358201&t=ac690a76-5e9e-5c44-1f80-b71727af3e77&l=123 By any chance would you have any ideas if this is expected / related to changes in this release? edit: Looks like the introduction of |
This error:
The signal is not strictly necessary. I added it as GSD 3.0 aggressively buffers writes in memory to improve performance. Users would expect to find that data in the file when their scripts are asked to terminate. |
Thanks @joaander Seems like this is killing A side thought, given that it's being throw on what appears to be some kind of multithreaded call - how well tested is the current release with multiprocessing approaches? |
I haven't experience any issues in my testing in production environments. I have some unit tests that use gsd in combination with multiprocessing to read frames in parallel. Nothing in GSD is engineered for thread or process safe read/write access to the same file. Given the nature of your error, I assume it is related to something specific in how xdist operates and not how typical users will use the software. Feel free submit a PR that works around the issue. |
I opened #257 to discuss the unexpected behavior which is not related to the steps needed to release 3.0.0. |
Release checklist:
comm -13 <(git log LAST_TAG --format="%aN <%aE>" | sort | uniq) <(git log --format="%aN <%aE>" | sort | uniq)
.Add entries to
.mailmap
to remove duplicates.The text was updated successfully, but these errors were encountered: