Fix ValueError when importing gsd in a non-main thread.
#258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows users to `import gsd` in a separate thread.
joaander
requested review from
a team,
tommy-waltmann and
yuanzhou0827
and removed request for
a team
3 tasks
tommy-waltmann
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Catch and ignore
ValueErrorraised bysignal.signal.Motivation and Context
Downstream users running xdist report failures: #255 (comment).
I can't imagine that users would separate their imports into a separate Python thread during normal production use.
Resolves #257.
How Has This Been Tested?
I executed the test case in #257 before and after the fix.
It is not possible to test this in pytest (without xdist), as gsd will have been imported into the interpreter before any threading test starts.
Checklist:
doc/credits.rst) in the pull request source branch.CHANGELOG.rst.