Add Custom Asset to ITIL Link Types from Definition

[cconard96]

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	-

[AdrienClairembault]

Looks good; we probably need a few tests to ensure everything stays working:

• For e2e, test the js toggle + make sure the value are saved ?
• For PHPunit not sure what is the "highest level" point of the code where we can properly test the feature but we still need something I guess

[orthagh]

The design seems a bit odd to me, I said the same thing yesterday in Caen office (I forgot to write my opinion since)
I'm not a big fan of the "Show extra fields" toggle that seems to be here to hide the mess under :p

Some suggestions:

• maybe we could find a shorter label and try to include it in the main rows
• otherwise, maybe align the thing to the left, and remove the border-bottom of the above rows

In both cases, the top toggle seems not useful

[cconard96]

* maybe we could find a shorter label and try to include it in the main rows

I tried that first. It seemed messy to handle the display of the checkbox matrix and handling the permissions on the server side. It also means that we have a lot of horizontal scrolling. Finally, I don't know how many options like this we will end up adding (or have plugins add), but maybe not all can be displayed as a checkbox.

* otherwise, maybe align the thing to the left, and remove the border-bottom of the above rows

The alignment wasn't intentional, but it does help show that it is part of the Profile listed above it. Removing the border is a good idea. It would require some changes to the checkbox matrix template to allow it.

In both cases, the top toggle seems not useful

It was just a way to hide the extra fields if the interest is only in the basic permissions. If you have a lot of Profiles and/or if we add a lot more of these extra fields, it could be a lot of scrolling to find the Profiles you want without using the browser search. Maybe a search box to filter the displayed Profiles would be better?

[cedric-anne]

And what about displaying a unique field at the end of the rights matrix that would permit to select the list of profiles that should be able to use this kind of asset in ITIL context ?

[orthagh]

maybe an idea yes. Note sure atm, but I take other opinions

[cedric-anne]

ping @orthagh

What should we do with this PR?