Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Feat) ‘Virtualisation system’ criterion in the rules #17797

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

(Feat) ‘Virtualisation system’ criterion in the rules #17797

wants to merge 8 commits into from
+319 −7

Conversation

Lainow
Copy link
Contributor

@Lainow Lainow commented Sep 5, 2024 •
edited
Loading

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

Addition of a new ‘Virtualisation system’ criterion in the rules for importing and linking equipment (for Computers). (Ticket : !33353)

Screenshots (if appropriate):

image

@Lainow Lainow changed the title Feat virtualmachinetype rule (Feat) New ‘Virtualisation system’ criterion in the rules Sep 5, 2024
@Lainow Lainow changed the title (Feat) New ‘Virtualisation system’ criterion in the rules (Feat) ‘Virtualisation system’ criterion in the rules Sep 5, 2024
@Lainow Lainow force-pushed the feat-virtualmachinetype-rule branch from 2c216ce to e0e30e2 Compare September 5, 2024 10:14
@Lainow Lainow force-pushed the feat-virtualmachinetype-rule branch from e0e30e2 to bc120ac Compare September 5, 2024 10:19
@Lainow Lainow requested a review from trasher September 5, 2024 13:01
stonebuzz
stonebuzz approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@stonebuzz stonebuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok to me, let's wait for the customer's feedback

cedric-anne
cedric-anne previously requested changes Sep 9, 2024
View reviewed changes
Copy link
Member

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing.

@cedric-anne cedric-anne added this to the 11.0.0 milestone Sep 9, 2024
@trasher
Copy link
Contributor

trasher commented Sep 10, 2024

Tests are still failing

trasher
trasher approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@trasher trasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should wait for customer validation before merge

@cedric-anne cedric-anne dismissed their stale review September 11, 2024 14:00

Tests have been fixed.

@Lainow Lainow self-assigned this Sep 19, 2024
@cedric-anne cedric-anne marked this pull request as draft September 30, 2024 12:01
@cedric-anne
Copy link
Member

I changed the status to draft as we are still waiting for the customer's feedback.

@Lainow Please warn us when all will be OK for the customer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trasher trasher trasher approved these changes

@stonebuzz stonebuzz stonebuzz approved these changes

@AdrienClairembault AdrienClairembault AdrienClairembault approved these changes

@cedric-anne cedric-anne Awaiting requested review from cedric-anne

Assignees

@Lainow Lainow

Labels
enhancement
Projects
None yet
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Lainow @trasher @cedric-anne @stonebuzz @AdrienClairembault