Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actionsheet v1 - scroll lock should not kick in if backdrop is not rendered #2450

Closed
1 of 6 tasks
FezVrasta opened this issue Sep 4, 2024 · 5 comments
Closed
1 of 6 tasks
Assignees
Labels
bug Something isn't working

Comments

@FezVrasta
Copy link
Contributor

Description

When I use the Actionsheet component without a backdrop I can't scroll the page. If I don't use a backdrop I would expect the background scroll to work.

CodeSandbox/Snack link

n/a

Steps to reproduce

  1. Go to '...'
  2. Click on '...'
  3. Scroll down to '...'
  4. See error

gluestack-ui Version

@gluestack-ui/actionsheet: 0.2.44

Platform

  • Expo
  • React Native CLI
  • Next
  • Web
  • Android
  • iOS

Other Platform

No response

Additional Information

No response

@FezVrasta FezVrasta added the bug Something isn't working label Sep 4, 2024
@rajat693
Copy link
Collaborator

rajat693 commented Sep 5, 2024

hi @FezVrasta, thanks for reporting the issue, we will have a look.

@rajat693
Copy link
Collaborator

rajat693 commented Sep 6, 2024

hi @FezVrasta, Thank you for your suggestion! ActionSheets typically freeze background content to maintain focus. For scrollable background content, we recommend using our customizable Popover component instead.

@FezVrasta
Copy link
Contributor Author

Thanks but they do look quite different and don't provide the same interactions (like being resizable).

Native action sheet on ios has an option to allow for background interaction and it's widely used, see Apple Maps, Flighty, and more

@rajat693
Copy link
Collaborator

rajat693 commented Sep 9, 2024

Thanks for your suggestion @FezVrasta, we'll review it and plan to update this feature in our actionsheet in the future.

@FezVrasta
Copy link
Contributor Author

@rajat693 I sent a PR to address this issue if you would like to review it.

Viraj-10 added a commit that referenced this issue Sep 19, 2024
Fixes #2450 -- Actionsheet scroll prevention only when backdrop is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants
@FezVrasta @rajat693 and others