Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/@gluestack style/react@1.0.37 #1617

Merged
merged 7 commits into from
Jan 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/styled/react/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
# @gluestack-style/react

## 1.0.37

### Patch Changes

- # Color mode switch issue fixes

## 1.0.36

### Patch Changes

- - Fixed data theme id attribute
- Fixed data theme id attribute

## 1.0.35

Expand Down
2 changes: 1 addition & 1 deletion packages/styled/react/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@gluestack-style/react",
"description": "A universal & performant styling library for React Native, Next.js & React",
"version": "1.0.36",
"version": "1.0.37",
"keywords": [
"React Native",
"Next.js",
Expand Down
56 changes: 27 additions & 29 deletions packages/styled/react/src/StyledProvider.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import { resolveThemes } from './createConfig';

type Config = any;
let colorModeSet = false;
let rootId = '';

export const defaultConfig: {
config: Config;
Expand All @@ -33,7 +34,6 @@ const StyledContext = React.createContext<Config>(defaultContextData);

const setCurrentColorMode = (inputColorMode: string | undefined) => {
if (inputColorMode) {
// console.log(get(), '>>>>>>');
const currentColorMode = get();
if (currentColorMode !== inputColorMode) {
set(inputColorMode);
Expand Down Expand Up @@ -66,8 +66,13 @@ export const StyledProvider: React.FC<{

const { themes } = useTheme();
const styledContext = useStyled();
const isParentProviderExist =
Object.keys(styledContext?.config).length > 0 ? true : false;
const id = React.useId();

if (rootId === '') {
rootId = id;
}

const isRootProvider = rootId === id;

const themeContextValue = React.useMemo(() => {
if (colorMode) {
Expand Down Expand Up @@ -137,55 +142,47 @@ export const StyledProvider: React.FC<{
// Add gs class name
if (Platform.OS === 'web') {
documentElement.classList.add(`gs`);

if (currentColorMode) {
if (!isParentProviderExist) {
if (isRootProvider) {
if (currentColorMode) {
documentElement
.querySelector('body')
?.setAttribute('data-theme-id', currentColorMode);
documentElement.classList.add(`gs-${currentColorMode}`);
}
} else {
if (!isParentProviderExist) {
} else {
documentElement.classList.add(`gs-light`);
}
}
}

onChange((currentColor: string) => {
// only for web
if (Platform.OS === 'web' && !_experimentalNestedProvider) {
const documentElement = document.documentElement;

if (Platform.OS === 'web') {
if (isRootProvider) {
if (currentColor) {
if (currentColor === 'dark') {
if (!isParentProviderExist) {
documentElement
.querySelector('body')
?.setAttribute('data-theme-id', 'dark');
documentElement.classList.remove(`gs-light`);
}
documentElement
.querySelector('body')
?.setAttribute('data-theme-id', 'dark');
documentElement.classList.remove(`gs-light`);
} else {
if (!isParentProviderExist) {
documentElement
.querySelector('body')
?.setAttribute('data-theme-id', 'light');
documentElement.classList.remove(`gs-dark`);
}
}
if (!isParentProviderExist) {
documentElement.classList.add(`gs-${currentColor}`);
documentElement
.querySelector('body')
?.setAttribute('data-theme-id', 'light');
documentElement.classList.remove(`gs-dark`);
}
documentElement.classList.add(`gs-${currentColor}`);
}
}
}
});

// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);

React.useEffect(() => {
setCurrentColorMode(currentColorMode);
if (isRootProvider) {
setCurrentColorMode(currentColorMode);
}
}, [currentColorMode]);

useSafeLayoutEffect(() => {
Expand Down Expand Up @@ -224,7 +221,7 @@ export const StyledProvider: React.FC<{
}
});
// // Set colormode for the first time
if (!colorModeSet) {
if (!colorModeSet && isRootProvider) {
setCurrentColorMode(currentColorMode);
}

Expand All @@ -239,6 +236,7 @@ export const StyledProvider: React.FC<{
animationDriverData,
setAnimationDriverData,
inlineStyleMap: inlineStyleMap.current,
isConfigSet: true,
};

if (_experimentalNestedProvider) {
Expand Down