Manual implementation of Debug trait for SymbolKind and CompletionItemKind as they are no longer Enums
#221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krobelus
reviewed
Oct 31, 2021
| @@ -1099,6 +1099,40 @@ impl SymbolKind { | |||
| pub const TYPE_PARAMETER: SymbolKind = SymbolKind(26); | |||
| } | |||
|
|
|||
| impl Debug for SymbolKind { | |||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | |||
There was a problem hiding this comment.
Nice find, thanks. IMO these stringified representations (with the official LSP names) should definitely be exposed, because they are good enough for many clients.
I wondered if we should implement Display instead of Debug because at least kak-lsp shows this to the user. Then again _ => write!(f, "SymbolKind({})", self.0), feel more at home in Debug, so I think it's fine.
In future it would be nice to have the same for the other 16 enum-turned-struct types. Maybe someone can devise a proc-macro to generate the methods - we just need to convert SOME_NAME to SomeName everywhere.
sidkshatriya
force-pushed
the
debug-trait-symbol-kind
branch
from
5fa1139
to
5b32fe4
Compare
…it is not an Enum
|
Made a similar change for |
sidkshatriya
changed the title
SymbolKind and CompletionItemKind as they are no longer Enums
Marwes
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SymbolKindis no longer an Enum. The Debug trait needs to be manually implemented to prevent a regression downstream.See kakoune-lsp/kakoune-lsp#550