Merge branch 'master' into tm/polling-duration-stats

* master:
  [APM] Define placement “Right” to offset tooltip (elastic#87729)
  Fix UI glitch on SOM delete confirmation modal (elastic#87623)
  Remove src/plugins/vis_default_editor -> src/plugins/visualizations cyclic dependencies (elastic#86988)
  [Timelion] Fix tests flakiness on suggestion click (elastic#87273)
  [Uptime] Fix/details page tabs (elastic#86296)
  [ML] Fix earliest and latest texts for date fields (elastic#87482)
  chore(NA): move grokdebugger plugin test fixtures out of __tests__ folder (elastic#87765)
  [Security Solution] Refactor Cypress scenarios to use internal contex… (elastic#86609)
  [Security Solution] Unskip cypress tests (elastic#86653)

package.json

@@ -352,7 +352,7 @@
     "@babel/traverse": "^7.11.5",
     "@babel/types": "^7.11.0",
     "@cypress/snapshot": "^2.1.7",
-    "@cypress/webpack-preprocessor": "^5.4.11",
+    "@cypress/webpack-preprocessor": "^5.5.0",
     "@elastic/apm-rum": "^5.6.1",
     "@elastic/apm-rum-react": "^1.2.5",
     "@elastic/charts": "24.4.0",
@@ -607,7 +607,7 @@
     "cpy": "^8.1.1",
     "cronstrue": "^1.51.0",
     "css-loader": "^3.4.2",
-    "cypress": "^6.1.0",
+    "cypress": "^6.2.1",
     "cypress-cucumber-preprocessor": "^2.5.2",
     "cypress-multi-reporters": "^1.4.0",
     "d3": "3.5.17",

packages/kbn-es-archiver/src/actions/empty_kibana_index.ts

@@ -20,7 +20,7 @@
 import { Client } from 'elasticsearch';
 import { ToolingLog, KbnClient } from '@kbn/dev-utils';
 
-import { migrateKibanaIndex, deleteKibanaIndices, createStats } from '../lib';
+import { migrateKibanaIndex, createStats, cleanKibanaIndices } from '../lib';
 
 export async function emptyKibanaIndexAction({
   client,
@@ -32,8 +32,9 @@ export async function emptyKibanaIndexAction({
   kbnClient: KbnClient;
 }) {
   const stats = createStats('emptyKibanaIndex', log);
+  const kibanaPluginIds = await kbnClient.plugins.getEnabledIds();
 
-  await deleteKibanaIndices({ client, stats, log });
+  await cleanKibanaIndices({ client, stats, log, kibanaPluginIds });
   await migrateKibanaIndex({ client, kbnClient });
   return stats;
 }

packages/kbn-es-archiver/src/lib/index.ts

@@ -25,6 +25,7 @@ export {
   createGenerateIndexRecordsStream,
   deleteKibanaIndices,
   migrateKibanaIndex,
+  cleanKibanaIndices,
   createDefaultSpace,
 } from './indices';
 

packages/kbn-es-archiver/src/lib/indices/index.ts

@@ -20,4 +20,9 @@
 export { createCreateIndexStream } from './create_index_stream';
 export { createDeleteIndexStream } from './delete_index_stream';
 export { createGenerateIndexRecordsStream } from './generate_index_records_stream';
-export { migrateKibanaIndex, deleteKibanaIndices, createDefaultSpace } from './kibana_index';
+export {
+  migrateKibanaIndex,
+  deleteKibanaIndices,
+  cleanKibanaIndices,
+  createDefaultSpace,
+} from './kibana_index';

packages/kbn-es-archiver/src/lib/indices/kibana_index.ts

@@ -73,6 +73,7 @@ export async function migrateKibanaIndex({
     body: {
       dynamic: true,
     },
+    ignore: [404],
   } as any);
 
   await kbnClient.savedObjects.migrate();

src/dev/run_find_plugins_with_circular_deps.ts

@@ -31,7 +31,6 @@ interface Options {
 type CircularDepList = Set<string>;
 
 const allowedList: CircularDepList = new Set([
-  'src/plugins/vis_default_editor -> src/plugins/visualizations',
   'src/plugins/visualizations -> src/plugins/visualize',
   'x-pack/plugins/actions -> x-pack/plugins/case',
   'x-pack/plugins/case -> x-pack/plugins/security_solution',

src/plugins/data/public/ui/filter_bar/filter_item.tsx

@@ -153,7 +153,14 @@ export function FilterItem(props: Props) {
     const dataTestSubjNegated = filter.meta.negate ? 'filter-negated' : '';
     const dataTestSubjDisabled = `filter-${isDisabled(labelConfig) ? 'disabled' : 'enabled'}`;
     const dataTestSubjPinned = `filter-${isFilterPinned(filter) ? 'pinned' : 'unpinned'}`;
-    return `filter ${dataTestSubjDisabled} ${dataTestSubjKey} ${dataTestSubjValue} ${dataTestSubjPinned} ${dataTestSubjNegated}`;
+    return classNames(
+      'filter',
+      dataTestSubjDisabled,
+      dataTestSubjKey,
+      dataTestSubjValue,
+      dataTestSubjPinned,
+      dataTestSubjNegated
+    );
   }
 
   function getPanels() {

src/plugins/region_map/kibana.json

@@ -15,7 +15,7 @@
   ],
   "requiredBundles": [
     "kibanaUtils",
-    "charts", 
+    "charts",
     "visDefaultEditor"
   ]
 }

src/plugins/region_map/public/region_map_type.js

@@ -22,7 +22,6 @@ import { mapToLayerWithId } from './util';
 import { createRegionMapVisualization } from './region_map_visualization';
 import { RegionMapOptions } from './components/region_map_options';
 import { truncatedColorSchemas } from '../../charts/public';
-import { Schemas } from '../../vis_default_editor/public';
 import { ORIGIN } from '../../maps_legacy/public';
 import { getDeprecationMessage } from './get_deprecation_message';
 
@@ -64,7 +63,7 @@ provided base maps, or add your own. Darker colors represent higher values.',
         vectorLayers: [],
         tmsLayers: [],
       },
-      schemas: new Schemas([
+      schemas: [
         {
           group: 'metrics',
           name: 'metric',
@@ -98,7 +97,7 @@ provided base maps, or add your own. Darker colors represent higher values.',
           max: 1,
           aggFilter: ['terms'],
         },
-      ]),
+      ],
     },
     setup: async (vis) => {
       const serviceSettings = await getServiceSettings();