Merge branch 'alerting/lazy-load-actions' into alerting/lazy-load-com…

…ponents

* alerting/lazy-load-actions:
  align and style loading indicator
  [ML] Transforms: Fix API error message display for edit flyout. (elastic#65494)
  [SIEM][Detection Engine] Fixes import bug with non existent signals index (elastic#65595)
  [Lens] Use rules of hooks with linting (elastic#65593)
  [ML] Migrate server side Mocha tests to Jest. (elastic#65651)
  Fixes the client to setup SSL with the CA certificates for testing (elastic#65598)
  reduce uptime plugin initial bundle size (elastic#65257)
  [ML] Consolidating shared types and util functions (elastic#65247)
  [Drilldowns] Preserve state when selecting different action factory (elastic#65074)
  Migrate test plugins ⇒ NP (kbn_tp_embeddable_explorer) (elastic#64756)
  Move remaining home assets to the new platform (elastic#65053)
  Change the copy and the id from blacklist to block list for consistency (elastic#65419)
  [ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522)
  [ML] Fix the limit control on the Anomaly explorer page (elastic#65459)
  [Mappings editor] Add component integration tests (elastic#63853)
  [Logs + Metrics UI] Prevent component errors from breaking the whole UI (elastic#65456)
  [Logs UI] Disable search bar when live stream is on. (elastic#65491)

.eslintrc.js

@@ -112,7 +112,6 @@ module.exports = {
       files: ['x-pack/plugins/lens/**/*.{js,ts,tsx}'],
       rules: {
         'react-hooks/exhaustive-deps': 'off',
-        'react-hooks/rules-of-hooks': 'off',
       },
     },
     {

src/plugins/dashboard/public/application/dashboard_empty_screen.tsx

@@ -50,8 +50,8 @@ export function DashboardEmptyScreen({
 }: DashboardEmptyScreenProps) {
   const IS_DARK_THEME = uiSettings.get('theme:darkMode');
   const emptyStateGraphicURL = IS_DARK_THEME
-    ? '/plugins/kibana/home/assets/welcome_graphic_dark_2x.png'
-    : '/plugins/kibana/home/assets/welcome_graphic_light_2x.png';
+    ? '/plugins/home/assets/welcome_graphic_dark_2x.png'
+    : '/plugins/home/assets/welcome_graphic_light_2x.png';
   const linkToVisualizeParagraph = (
     <p data-test-subj="linkToVisualizeParagraph">
       <EuiButton

src/plugins/home/public/application/components/sample_data/index.tsx

@@ -42,7 +42,7 @@ interface Props {
 export function SampleDataCard({ urlBasePath, onDecline, onConfirm }: Props) {
   return (
     <EuiCard
-      image={`${urlBasePath}/plugins/kibana/home/assets/illustration_elastic_heart.png`}
+      image={`${urlBasePath}/plugins/home/assets/illustration_elastic_heart.png`}
       textAlign="left"
       title={<FormattedMessage id="home.letsStartTitle" defaultMessage="Let's get started" />}
       description={

src/plugins/home/server/services/sample_data/data_sets/ecommerce/index.ts

@@ -36,8 +36,8 @@ export const ecommerceSpecProvider = function(): SampleDatasetSchema {
     id: 'ecommerce',
     name: ecommerceName,
     description: ecommerceDescription,
-    previewImagePath: '/plugins/kibana/home/sample_data_resources/ecommerce/dashboard.png',
-    darkPreviewImagePath: '/plugins/kibana/home/sample_data_resources/ecommerce/dashboard_dark.png',
+    previewImagePath: '/plugins/home/assets/sample_data_resources/ecommerce/dashboard.png',
+    darkPreviewImagePath: '/plugins/home/assets/sample_data_resources/ecommerce/dashboard_dark.png',
     overviewDashboard: '722b74f0-b882-11e8-a6d9-e546fe2bba5f',
     appLinks: initialAppLinks,
     defaultIndex: 'ff959d40-b880-11e8-a6d9-e546fe2bba5f',

src/plugins/home/server/services/sample_data/data_sets/flights/index.ts

@@ -36,8 +36,8 @@ export const flightsSpecProvider = function(): SampleDatasetSchema {
     id: 'flights',
     name: flightsName,
     description: flightsDescription,
-    previewImagePath: '/plugins/kibana/home/sample_data_resources/flights/dashboard.png',
-    darkPreviewImagePath: '/plugins/kibana/home/sample_data_resources/flights/dashboard_dark.png',
+    previewImagePath: '/plugins/home/assets/sample_data_resources/flights/dashboard.png',
+    darkPreviewImagePath: '/plugins/home/assets/sample_data_resources/flights/dashboard_dark.png',
     overviewDashboard: '7adfa750-4c81-11e8-b3d7-01146121b73d',
     appLinks: initialAppLinks,
     defaultIndex: 'd3d7af60-4c81-11e8-b3d7-01146121b73d',

src/plugins/home/server/services/sample_data/data_sets/logs/index.ts

@@ -36,8 +36,8 @@ export const logsSpecProvider = function(): SampleDatasetSchema {
     id: 'logs',
     name: logsName,
     description: logsDescription,
-    previewImagePath: '/plugins/kibana/home/sample_data_resources/logs/dashboard.png',
-    darkPreviewImagePath: '/plugins/kibana/home/sample_data_resources/logs/dashboard_dark.png',
+    previewImagePath: '/plugins/home/assets/sample_data_resources/logs/dashboard.png',
+    darkPreviewImagePath: '/plugins/home/assets/sample_data_resources/logs/dashboard_dark.png',
     overviewDashboard: 'edf84fe0-e1a0-11e7-b6d5-4dc382ef7f5b',
     appLinks: initialAppLinks,
     defaultIndex: '90943e30-9a47-11e8-b64d-95841ca0b247',

test/common/services/elasticsearch.ts

@@ -18,15 +18,19 @@
  */
 
 import { format as formatUrl } from 'url';
-
+import fs from 'fs';
 import { Client } from '@elastic/elasticsearch';
+import { CA_CERT_PATH } from '@kbn/dev-utils';
 
 import { FtrProviderContext } from '../ftr_provider_context';
 
 export function ElasticsearchProvider({ getService }: FtrProviderContext) {
   const config = getService('config');
 
   return new Client({
+    ssl: {
+      ca: fs.readFileSync(CA_CERT_PATH, 'utf-8'),
+    },
     nodes: [formatUrl(config.get('servers.elasticsearch'))],
     requestTimeout: config.get('timeouts.esRequestTimeout'),
   });

test/plugin_functional/plugins/kbn_tp_embeddable_explorer/kibana.json

@@ -0,0 +1,16 @@
+{
+  "id": "kbn_tp_embeddable_explorer",
+  "version": "0.0.1",
+  "kibanaVersion": "kibana",
+  "requiredPlugins": [
+    "visTypeMarkdown",
+    "visTypeVislib",
+    "data",
+    "embeddable",
+    "uiActions",
+    "inspector",
+    "discover"
+  ],
+  "server": false,
+  "ui": true
+}

test/plugin_functional/plugins/kbn_tp_embeddable_explorer/public/np_ready/public/app/dashboard_container_example.tsx → test/plugin_functional/plugins/kbn_tp_embeddable_explorer/public/app/dashboard_container_example.tsx

@@ -24,7 +24,7 @@ import {
   DASHBOARD_CONTAINER_TYPE,
   DashboardContainer,
   DashboardContainerInput,
-} from '../../../../../../../../src/plugins/dashboard/public';
+} from '../../../../../../src/plugins/dashboard/public';
 
 import { dashboardInput } from './dashboard_input';
 

test/plugin_functional/plugins/kbn_tp_embeddable_explorer/public/np_ready/public/app/dashboard_input.ts → test/plugin_functional/plugins/kbn_tp_embeddable_explorer/public/app/dashboard_input.ts

@@ -18,7 +18,7 @@
  */
 
 import { ViewMode, CONTACT_CARD_EMBEDDABLE, HELLO_WORLD_EMBEDDABLE } from '../embeddable_api';
-import { DashboardContainerInput } from '../../../../../../../../src/plugins/dashboard/public';
+import { DashboardContainerInput } from '../../../../../../src/plugins/dashboard/public';
 
 export const dashboardInput: DashboardContainerInput = {
   panels: {

test/plugin_functional/plugins/kbn_tp_embeddable_explorer/public/np_ready/public/embeddable_api.ts → test/plugin_functional/plugins/kbn_tp_embeddable_explorer/public/embeddable_api.ts

@@ -17,6 +17,9 @@
  * under the License.
  */
 
-export * from '../../../../../../../src/plugins/embeddable/public';
-export * from '../../../../../../../src/plugins/embeddable/public/lib/test_samples';
-export { HELLO_WORLD_EMBEDDABLE } from '../../../../../../../examples/embeddable_examples/public';
+export * from '../../../../../src/plugins/embeddable/public';
+export * from '../../../../../src/plugins/embeddable/public/lib/test_samples';
+export {
+  HELLO_WORLD_EMBEDDABLE,
+  HelloWorldEmbeddableFactory,
+} from '../../../../../examples/embeddable_examples/public';