Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: minimal teams package #2654

Closed

Conversation

irreverentsimplicity
Copy link
Contributor

This PR adds a minimal team functionality, leveraging the p/demo/users realm.

Rationale:

  • on top of users, there might be cases when we need agnostic representation of teams (ZenTasktic is such a case)
  • the package is kept minimalistic, leaving the task of enriching the data types to the realms importing it (but it still provides functions for adding / removing users, and setting the team creator - getters can be implemented by each realm, according to their needs)
  • a teams object that is identified with a specific on-chain address allows for the team to hold funds or other assets. Disbursing these funds can be done using other packages, like disperse.

AFAIK, no breaking changes have been introduced.

@irreverentsimplicity irreverentsimplicity requested review from zivkovicmilos and removed request for a team August 2, 2024 05:04
@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related labels Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 60.20067% with 119 lines in your changes missing coverage. Please review.

Project coverage is 59.91%. Comparing base (01ee5a9) to head (71ca7b8).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
gno.land/pkg/gnoland/app.go 0.00% 51 Missing ⚠️
gno.land/pkg/sdk/vm/keeper.go 64.64% 34 Missing and 1 partial ⚠️
gno.land/pkg/gnoland/node_inmemory.go 0.00% 15 Missing ⚠️
gno.land/pkg/gnoclient/client_txs.go 78.12% 6 Missing and 8 partials ⚠️
gno.land/pkg/integration/testing_node.go 70.00% 3 Missing ⚠️
gno.land/pkg/gnoclient/signer.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2654      +/-   ##
==========================================
- Coverage   60.84%   59.91%   -0.94%     
==========================================
  Files         563      560       -3     
  Lines       75190    76305    +1115     
==========================================
- Hits        45753    45715      -38     
- Misses      26068    27126    +1058     
- Partials     3369     3464      +95     
Flag Coverage Δ
contribs/gnodev 61.40% <100.00%> (+0.75%) ⬆️
contribs/gnofaucet 15.31% <ø> (+0.85%) ⬆️
gno.land 64.15% <59.66%> (-3.02%) ⬇️
gnovm 64.22% <ø> (-1.42%) ⬇️
misc/genstd 80.54% <ø> (ø)
misc/logos 19.88% <ø> (ø)
tm2 62.07% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@irreverentsimplicity irreverentsimplicity changed the title Minimal Teams package feat: minimal teams package Aug 12, 2024
@leohhhn
Copy link
Contributor

leohhhn commented Sep 19, 2024

Hey @irreverentsimplicity, can you see to fix this PR? Theres 356 changed files, I assume because of git. I'll take a look at it right after, please ping me.

@ajnavarro ajnavarro removed their request for review September 20, 2024 13:21
@irreverentsimplicity
Copy link
Contributor Author

Obsoleted by #2830, I will close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants