Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added Abs() funcs, support for overflow for uints + tests #2905

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MalekLahbib
Copy link
Contributor

the files were updated from https://github.com/rwxe/overflow (MIT).
Added Abs functions to get the absolute value of an int.
Added functions to support overflow for uints.
Added tests for the new functions.

the final file "overflow.gno" is very long (1000 lines). Is it good? or is it possible/necessary to cut in many files?

@jaekwon can you take a look as the old code is yours?

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.94%. Comparing base (8a62a28) to head (be92319).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2905      +/-   ##
==========================================
- Coverage   60.95%   60.94%   -0.01%     
==========================================
  Files         564      564              
  Lines       75273    75273              
==========================================
- Hits        45884    45878       -6     
- Misses      26019    26022       +3     
- Partials     3370     3373       +3     
Flag Coverage Δ
contribs/gnodev 61.46% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (ø)
gno.land 67.92% <ø> (ø)
gnovm 65.77% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 19.88% <ø> (ø)
tm2 61.96% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: No status
Status: Triage
Development

Successfully merging this pull request may close these issues.

1 participant