-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: relocate tm2/std.MemFile in gnovm/std #2910
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2910 +/- ##
==========================================
- Coverage 60.97% 60.95% -0.03%
==========================================
Files 564 565 +1
Lines 75273 75288 +15
==========================================
- Hits 45901 45889 -12
- Misses 26005 26029 +24
- Partials 3367 3370 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I chose to create I removed the .pb.go files that were added forcefully. Should I revert this change? |
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
I have a more general question - why do we name anything |
Right now, we refer to these as "lowest level types." The closest name we have is "sys," and the system contracts are currently named "r/sys." We also considered naming them "r/std." Essentially, this serves as our standard for low-level system components. In this repository, we have three standard packages designed to be imported to connect with the components without loading other parts (lightweight, no side effects). An alternative for the Go side would be to rename them to "types." However, it's important to distinguish between "system/low-level types" and "all types." One invites connection with a minimal API (communication layer), while the other is more internal and advanced. I'm open to reconsidering a renaming, although I believe we will likely prefer to stick with the current approach. My question is about balancing independence with unifying gnovm's standard messages. |
Signed-off-by: moul <94029+moul@users.noreply.github.com>
By the way, the relocation is complete, and the CI is green. I have two other PRs in mind that will depend on merging this one. Please feel free to review it, and we can discuss the "naming" topic later, maybe. |
Signed-off-by: moul <94029+moul@users.noreply.github.com>
This PR removes "gno.land" from all
tm2/.../*.go
files.