Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gno.land): Implement markdown package #2912

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sunspirit99
Copy link
Contributor

From #2753

I keep this PR open to see if I am on the right approach. If it's suitable, I'll investigate to make further improvements and provide implementation examples in the Render() functions of some current demo realms to demonstrate the use of this package

To-do :

  • Implement functionality for nested lists (both bullet and ordered) to provide more structure in the generated Markdown
  • Ensure that each function has clear documentation comments, describing its purpose and usage

cc @moul

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@sunspirit99 sunspirit99 requested review from a team as code owners October 5, 2024 12:59
@sunspirit99 sunspirit99 requested review from jaekwon and thehowl and removed request for a team October 5, 2024 12:59
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Oct 5, 2024
Copy link

codecov bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.95%. Comparing base (d3049ae) to head (6ac3db4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2912      +/-   ##
==========================================
- Coverage   60.97%   60.95%   -0.02%     
==========================================
  Files         564      564              
  Lines       75273    75273              
==========================================
- Hits        45901    45886      -15     
- Misses      26005    26017      +12     
- Partials     3367     3370       +3     
Flag Coverage Δ
contribs/gnodev 61.46% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (-0.86%) ⬇️
gno.land 67.92% <ø> (ø)
gnovm 65.78% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 19.88% <ø> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: No status
Status: Triage
Development

Successfully merging this pull request may close these issues.

1 participant