This repository has been archived by the owner on Apr 28, 2022. It is now read-only.
Investigate Why Coverage is Broken On Latest Nightly #1588
Comments
|
Relevant issue: taiki-e/cargo-llvm-cov#128 |
nlordell
added a commit
that referenced
this issue
Jan 21, 2022
This PR pins nightly to `2022-01-14` to fix the coverage report. It appears to be an issue with the nightly compiler (at least that is what is suggested in the `cargo-llvm-cov` project issues page). I created an issue so we don't forget to switch( back eventually #1588 (this also contains a link to the issue in the `cargo-llvm-cov` project for reference). This PR also introduces a small unrelated change: the [recommended way to install `cargo-llvm-cov` is to use a dedicated Github action](https://github.com/taiki-e/cargo-llvm-cov#continuous-integration), so this PR also changes the workflow to use it instead of the manual install it was doing previously. ### Test Plan CI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
As of 2022-01-15, our coverage step has been broken. While this may just be a regression in nightly, it has been for a little while so we should investigate why this is happening. It may be changes to lcov output that are incompatible with the tool that we use and may require some changes.
Creating an issue so we don't forget to look into this.
The text was updated successfully, but these errors were encountered: