proc/gdbserial: Added support for darwin/arm64 using gdbserver #2285

oxisto · 2020-12-31T16:43:46Z

This is an alternative fix for #2246 and one that might be easier to merge in than fixing the native darwin backend (see #2254).

Tests almost succeed, and it looks like those that do not, i.e. cgo-related ones, might be related to some Go 1.16 problems. I can provide a complete log of make test (it is currently running).

Fixes #2246

oxisto · 2020-12-31T16:58:47Z

Here is the log of running the tests on my M1 machine: test.log

But, somehow it looks like I broke darwin/amd64, meh.

oxisto · 2020-12-31T17:12:59Z

pkg/proc/gdbserial/gdbserver_conn_arm64.go

+package gdbserial
+
+const (
+	regnamePC = "pc"


It would probably be a good idea to define those constants somewhere else, since multiple backends might need to refer to them.

oxisto · 2020-12-31T17:13:33Z

Existing tests on amd64 should now all run flawlessly. Ready to review and open for suggestions how to improve it :)

aarzilli

Overall LGTM, just a couple of minor things, glad to see you made it work!

pkg/proc/native/support_sentinel.go

pkg/proc/gdbserial/gdbserver.go

aarzilli

LGTM

ebilling · 2021-01-02T00:31:33Z

I hate to ask, and I know this isn't the right place, but @oxisto, I can't get this to work on my setup. I've been pulling down every version you push to try them out.

Darwin_arm64 laptop,
go version devel +a508840c67 Tue Dec 15 16:31:07 2020 +0000 darwin/amd64
% dlv version
Delve Debugger
Version: 1.5.1
Build: 15456ea

When I try to debug something using Microsoft Code, I get:

could not launch process: stub exited while waiting for connection: exit status 0

This works on my old laptop just fine, so has to be part of the arm move. Have you run into this? Are there additional instructions required in the Readme.md?

aarzilli · 2021-01-02T08:35:26Z

Could be that you are using a version of go compiled for amd64.

oxisto · 2021-01-02T19:57:24Z

Could be that you are using a version of go compiled for amd64.

Yes, exactly. This PR adds support for darwin/arm64 binaries using a darwin/arm64 version of Go. All other combinations, such as using a amd64 go binary or to debug a amd64 binary using Rosetta 2 is not supported. Once this PR is done, I will have a look at what other options delve can support.

To test it, you can get the Go 1.16 beta that supports darwin/am64 from the Go downloads page: https://golang.org/dl/go1.16beta1.darwin-arm64.pkg. You should then be able to make install delve using this fork/branch. Afterwards, using dlv debug path-to-your-program.go should be able to debug your program.

You can even test it in Visual Studio code, but you probably need to download the very experimental arm64 builds of VSCode for that (https://code.visualstudio.com/insiders/# / https://code.visualstudio.com/sha/download?build=insider&os=darwin-arm64). I would not recommend this for any productive workflow yet.

ebilling · 2021-01-02T21:13:36Z

Thank you both. I had built the darwin/arm64 version of go, but vs code was still pointing to a different version, and not paying attention to my PATH. I appreciate the pointers @oxisto and @aarzilli. Thank you.

I tried out the experimental VSCode and it's working.

gitslav · 2021-01-02T23:58:49Z

@oxisto I think you forgot to bump up the version number in compat.go
https://github.com/oxisto/delve/blob/15456ea98f1ca3fb8379730ff46ae8e08a054ef2/pkg/goversion/compat.go#L11

aarzilli · 2021-01-03T09:26:42Z

@oxisto I think you forgot to bump up the version number in compat.go
https://github.com/oxisto/delve/blob/15456ea98f1ca3fb8379730ff46ae8e08a054ef2/pkg/goversion/compat.go#L11

That's going to be done by #2214

artspb · 2021-01-04T10:54:10Z

If you want to try it in GoLand, you can specify -Ddlv.path=/Users/artspb/path/to/arm64/dlv under Help | Edit Custom VM Options...

derekparker · 2021-01-04T16:50:59Z

pkg/proc/gdbserial/gdbserver.go

-		mask8  = 0x000f
-		mask16 = 0x00ff
-		mask32 = 0xffff
+		mask8  = 0xff


This has been fixed elsewhere, but we really should export these somewhere for consistency.

To be clear, I don't think this should happen in this patch, just making a note.

It makes more sense to do it after the compositeMemory.WriteMemory PR, since that changes some other things about registers, we should just go through op.DwarfRegisters.

derekparker

LGTM

zsyu9779 · 2021-01-09T06:39:30Z

when I try to debug
it's still display that

# runtime/cgo gcc_arm64.S:28:16: error: brackets expression not supported on this target stp x29, x30, [sp, #-96]! ^ gcc_arm64.S:32:2: error: unknown use of instruction mnemonic without a size suffix mov x29, sp ^ gcc_arm64.S:34:16: error: brackets expression not supported on this target stp x19, x20, [sp, #80] ^ gcc_arm64.S:37:16: error: brackets expression not supported on this target stp x21, x22, [sp, #64] ^ gcc_arm64.S:40:16: error: brackets expression not supported on this target stp x23, x24, [sp, #48] ^ gcc_arm64.S:43:16: error: brackets expression not supported on this target stp x25, x26, [sp, #32] ^ gcc_arm64.S:46:16: error: brackets expression not supported on this target stp x27, x28, [sp, #16] ^ gcc_arm64.S:50:2: error: unknown use of instruction mnemonic without a size suffix mov x19, x0 ^ gcc_arm64.S:51:2: error: unknown use of instruction mnemonic without a size suffix mov x20, x1 ^ gcc_arm64.S:52:2: error: unknown use of instruction mnemonic without a size suffix mov x0, x2 ^ gcc_arm64.S:54:2: error: invalid instruction mnemonic 'blr' blr x20 ^~~ gcc_arm64.S:55:2: error: invalid instruction mnemonic 'blr' blr x19 ^~~ gcc_arm64.S:57:16: error: brackets expression not supported on this target ldp x27, x28, [sp, #16] ^ gcc_arm64.S:60:16: error: brackets expression not supported on this target ldp x25, x26, [sp, #32] ^ gcc_arm64.S:63:16: error: brackets expression not supported on this target ldp x23, x24, [sp, #48] ^ gcc_arm64.S:66:16: error: brackets expression not supported on this target ldp x21, x22, [sp, #64] ^ gcc_arm64.S:69:16: error: brackets expression not supported on this target ldp x19, x20, [sp, #80] ^ gcc_arm64.S:72:16: error: brackets expression not supported on this target ldp x29, x30, [sp], #96

shortcircuit3 · 2021-01-12T19:33:15Z

I get this error when debugging

Failed to continue - runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation]
Unable to propogate EXC_BAD_ACCESS signal to target process and panic (see https://github.com/go-delve/delve/issues/852)
Last known immediate stacktrace (goroutine id 0):
	?:-1
		<unknown>
	:0
		<unknown>

xibolun · 2021-01-18T10:00:23Z

runtime/cgo gcc_arm64.S

check your go IDE is arm version? or you use another go version to run code?

dragonly · 2021-03-09T07:02:45Z

I still run into trouble debugging TiDB.

#2246 (comment)

…lve#2285) * Added support for reading darwin/arm64 using gdbserver * Trying to fix test failures * Addressing review comments

Added support for reading darwin/arm64 using gdbserver

f19b510

Trying to fix test failures

6d79255

oxisto force-pushed the darwin-arm64-lldb branch from c3be37d to 6d79255 Compare December 31, 2020 17:06

oxisto commented Dec 31, 2020

View reviewed changes

oxisto changed the title ~~proc/*: Added support for darwin/arm64 using gdbserver~~ proc/gdbserial: Added support for darwin/arm64 using gdbserver Dec 31, 2020

aarzilli reviewed Jan 1, 2021

View reviewed changes

pkg/proc/native/support_sentinel.go Outdated Show resolved Hide resolved

pkg/proc/gdbserial/gdbserver.go Outdated Show resolved Hide resolved

oxisto force-pushed the darwin-arm64-lldb branch from 18b72b1 to 1bc2568 Compare January 1, 2021 13:31

Addressing review comments

15456ea

oxisto force-pushed the darwin-arm64-lldb branch from 1bc2568 to 15456ea Compare January 1, 2021 13:37

aarzilli approved these changes Jan 1, 2021

View reviewed changes

derekparker reviewed Jan 4, 2021

View reviewed changes

derekparker approved these changes Jan 4, 2021

View reviewed changes

derekparker merged commit 57f033e into go-delve:master Jan 4, 2021

derekparker mentioned this pull request Jan 14, 2021

Failed to install on Macos Arm64 #2302

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

proc/gdbserial: Added support for darwin/arm64 using gdbserver #2285

proc/gdbserial: Added support for darwin/arm64 using gdbserver #2285

oxisto commented Dec 31, 2020 •

edited

Loading

oxisto commented Dec 31, 2020

oxisto Dec 31, 2020

oxisto commented Dec 31, 2020 •

edited

Loading

aarzilli left a comment

aarzilli left a comment

ebilling commented Jan 2, 2021

aarzilli commented Jan 2, 2021

oxisto commented Jan 2, 2021

ebilling commented Jan 2, 2021 •

edited

Loading

gitslav commented Jan 2, 2021 •

edited

Loading

aarzilli commented Jan 3, 2021

artspb commented Jan 4, 2021

derekparker Jan 4, 2021

derekparker Jan 4, 2021

aarzilli Jan 4, 2021

derekparker left a comment

zsyu9779 commented Jan 9, 2021 •

edited

Loading

shortcircuit3 commented Jan 12, 2021

xibolun commented Jan 18, 2021

dragonly commented Mar 9, 2021

proc/gdbserial: Added support for darwin/arm64 using gdbserver #2285

proc/gdbserial: Added support for darwin/arm64 using gdbserver #2285

Conversation

oxisto commented Dec 31, 2020 • edited Loading

oxisto commented Dec 31, 2020

oxisto Dec 31, 2020

Choose a reason for hiding this comment

oxisto commented Dec 31, 2020 • edited Loading

aarzilli left a comment

Choose a reason for hiding this comment

aarzilli left a comment

Choose a reason for hiding this comment

ebilling commented Jan 2, 2021

aarzilli commented Jan 2, 2021

oxisto commented Jan 2, 2021

ebilling commented Jan 2, 2021 • edited Loading

gitslav commented Jan 2, 2021 • edited Loading

aarzilli commented Jan 3, 2021

artspb commented Jan 4, 2021

derekparker Jan 4, 2021

Choose a reason for hiding this comment

derekparker Jan 4, 2021

Choose a reason for hiding this comment

aarzilli Jan 4, 2021

Choose a reason for hiding this comment

derekparker left a comment

Choose a reason for hiding this comment

zsyu9779 commented Jan 9, 2021 • edited Loading

shortcircuit3 commented Jan 12, 2021

xibolun commented Jan 18, 2021

dragonly commented Mar 9, 2021

oxisto commented Dec 31, 2020 •

edited

Loading

oxisto commented Dec 31, 2020 •

edited

Loading

ebilling commented Jan 2, 2021 •

edited

Loading

gitslav commented Jan 2, 2021 •

edited

Loading

zsyu9779 commented Jan 9, 2021 •

edited

Loading