service/dap: use address, not index to differentiate compound map keys #2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarzilli
approved these changes
Jan 8, 2021
abner-chenc
pushed a commit
to loongson/delve
that referenced
this pull request
Mar 1, 2024
go-delve#2291) * Use address, not index to differentiate compound map keys * Clean up calls to expectVarRegex Co-authored-by: Polina Sokolova <polinasok@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When keys are compound, the value is a type, which is not unique. The earlier version of this code used child index to differentiate, but that seems misleading given that maps are not indexed or ordered. Using the address as a differentiator will be closer to dlv's expression syntax for loading variables.