Skip to content

Commit

Permalink
Remove spurious DataAsync Error logging (#14599)
Browse files Browse the repository at this point in the history
Breaking the pipe is a valid way of killing a piped command and any error from
a broken cat-file batch command should be passed back up to the writer any way
therefore specifically logging it is unnecessary.

Signed-off-by: Andrew Thornton <art27@cantab.net>
  • Loading branch information
zeripath committed Feb 7, 2021
1 parent 5f248d0 commit e65cfab
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions modules/git/blob_nogogit.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ import (
"io"
"strconv"
"strings"

gitea_log "code.gitea.io/gitea/modules/log"
)

// Blob represents a Git object.
Expand All @@ -35,7 +33,6 @@ func (b *Blob) DataAsync() (io.ReadCloser, error) {
err := NewCommand("cat-file", "--batch").RunInDirFullPipeline(b.repoPath, stdoutWriter, stderr, strings.NewReader(b.ID.String()+"\n"))
if err != nil {
err = ConcatenateError(err, stderr.String())
gitea_log.Error("Blob.DataAsync Error: %v", err)
_ = stdoutWriter.CloseWithError(err)
} else {
_ = stdoutWriter.Close()
Expand Down

0 comments on commit e65cfab

Please sign in to comment.