Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create repo on push allows invalid names with slashes #10142

Closed
2 of 7 tasks
jimparis opened this issue Feb 4, 2020 · 1 comment · Fixed by #10145
Closed
2 of 7 tasks

Create repo on push allows invalid names with slashes #10142

jimparis opened this issue Feb 4, 2020 · 1 comment · Fixed by #10145

Comments

@jimparis
Copy link

jimparis commented Feb 4, 2020

  • Gitea version (or commit ref): 1.11.0+rc2-17-g0129e76ef
  • Git version: 2.20.1
  • Operating system: Debian
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No ("Push to create is not enabled for users." and "Push to create is not enabled for organizations.")
    • Not relevant
  • Log gist:

Description

With ENABLE_PUSH_CREATE_USER, all of this works fine from the command line:

git init test
cd test
echo hi > README.md
git add README.md
git commit -m 'Initial commit'
git remote add origin git@git.example.com:jim/foo/bar/test.git
git push --set-upstream origin master     # this works
git pull     # this works
cd ..
git clone git@git.example.com:jim/foo/bar/test.git test2     # this works

And things look OK at first glance in the UI...

image

or

image

But clicking on the repo pops up a browser auth prompt:

image

followed by a page saying just "invalid credentials".

I don't even know how to delete this repo now. Related to #9175 I assume.

@jimparis
Copy link
Author

jimparis commented Feb 4, 2020

Removing the repo from disk and the single corresponding row in the repositories table seems to have gotten rid of it cleanly.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant