Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix push-create SSH bugs #10145

Merged
merged 3 commits into from
Feb 5, 2020
Merged

Fix push-create SSH bugs #10145

merged 3 commits into from
Feb 5, 2020

Conversation

jolheiser
Copy link
Member

@jolheiser jolheiser commented Feb 5, 2020 •
edited
Loading

Fix #10142
Fix #10143

@jolheiser
Attempt to fix push-create SSH bugs
15bf75d 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser
Fix binding
1235f2b 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser
Invalid ctx
8bb2c12 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@techknowlogick techknowlogick added this to the 1.12.0 milestone Feb 5, 2020
@codecov-io
Copy link

Codecov Report

Merging #10145 into master will increase coverage by 0.02%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10145      +/-   ##
==========================================
+ Coverage   43.39%   43.42%   +0.02%     
==========================================
  Files         576      576              
  Lines       79628    79640      +12     
==========================================
+ Hits        34558    34583      +25     
+ Misses      40791    40782       -9     
+ Partials     4279     4275       -4
Impacted Files Coverage Δ
cmd/serv.go 2.84% <0%> (-0.05%) ⬇️
routers/private/serv.go 35.39% <100%> (+2.06%) ⬆️
services/pull/pull.go 32.43% <0%> (-1.51%) ⬇️
models/gpg_key.go 55.37% <0%> (+0.55%) ⬆️
modules/queue/workerpool.go 46.61% <0%> (+1.06%) ⬆️
modules/queue/unique_queue_disk_channel.go 54.48% <0%> (+1.92%) ⬆️
routers/repo/http.go 41.32% <0%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dcd305...8bb2c12. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 5, 2020
@jolheiser jolheiser marked this pull request as ready for review February 5, 2020 04:07
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 5, 2020
sapk
sapk reviewed Feb 5, 2020
View reviewed changes
cmd/serv.go Show resolved Hide resolved
@sapk sapk merged commit 95013fd into go-gitea:master Feb 5, 2020
@sapk
Copy link
Member

sapk commented Feb 5, 2020

@jolheiser please send backport

jolheiser added a commit to jolheiser/gitea that referenced this pull request Feb 5, 2020
@jolheiser
Fix push-create SSH bugs (go-gitea#10145)
aa56f0d 
* Attempt to fix push-create SSH bugs

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Fix binding

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Invalid ctx

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser jolheiser mentioned this pull request Feb 5, 2020
Merged
@sapk sapk added the backport/done All backports for this PR have been created label Feb 5, 2020
sapk pushed a commit that referenced this pull request Feb 5, 2020
@jolheiser
Fix push-create SSH bugs (#10145) (#10151)
2cd2614 
* Attempt to fix push-create SSH bugs

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Fix binding

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Invalid ctx

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@jolheiser jolheiser deleted the push_create_ssh branch March 6, 2023 20:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sapk sapk sapk approved these changes

@zeripath zeripath zeripath approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

Cloning creates empty repositories Create repo on push allows invalid names with slashes
7 participants
@jolheiser @codecov-io @sapk @zeripath @6543 @techknowlogick @GiteaBot