Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prompt users to create a new PR after pushing to a new branch #13196

Closed
kolaente opened this issue Oct 18, 2020 · 3 comments · Fixed by #25715
Closed

Prompt users to create a new PR after pushing to a new branch #13196

kolaente opened this issue Oct 18, 2020 · 3 comments · Fixed by #25715
Assignees
@kolaente
Labels
issue/duplicate The issue has already been reported.

Comments

@kolaente
Copy link
Member

As a user, I would like to see a prompt on the home page or repository page to create a new PR if I recently pushed to a new branch for which no PR exists yet so that I save clicking on the "new PR" button on the repo page.

This could be done purely through the db without any git calls since we already have all the data in the action table.

I think we can always assume the user has the rights to create a PR if they have the right to push to a new branch in that repo, so no need to check that.
We would just need another check if the repo pushed to is a fork to check with the head repo if a PR exists there and not in the fork repo.
@zeripath zeripath added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Oct 18, 2020
@lunny
Copy link
Member

lunny commented Oct 18, 2020

This is duplicated with #311

@kolaente kolaente mentioned this issue Dec 15, 2020
Closed
5 tasks
@kolaente kolaente self-assigned this Dec 15, 2020
@kolaente
Copy link
Member Author

I'm working on this.

@lunny
Copy link
Member

lunny commented Dec 17, 2020

Let's close #311 .

@kolaente kolaente mentioned this issue Dec 17, 2020
Closed
@jpraet jpraet mentioned this issue Mar 27, 2023
Closed
@lunny lunny closed this as completed Mar 29, 2023
@lunny lunny added issue/duplicate The issue has already been reported. and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Mar 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2023
6543 pushed a commit that referenced this issue Jul 8, 2023
@lunny
Newly pushed branches hints on repository home page (#25715)
6375419 
This PR will display a pull request creation hint on the repository home
page when there are newly created branches with no pull request. Only
the recent 6 hours and 2 updated branches will be displayed.

Inspired by #14003 
Replace #14003 
Resolves #311
Resolves #13196
Resolves #23743

co-authored by @kolaente
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kolaente kolaente

Labels
issue/duplicate The issue has already been reported.
Projects
None yet
Milestone
No milestone
3 participants
@lunny @zeripath @kolaente