Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft markdown isn't redered on release list #16610

Closed
2 of 6 tasks
viceice opened this issue Aug 3, 2021 · 4 comments · Fixed by #16634
Closed
2 of 6 tasks

Draft markdown isn't redered on release list #16610

viceice opened this issue Aug 3, 2021 · 4 comments · Fixed by #16634
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@viceice
Copy link
Contributor

viceice commented Aug 3, 2021 •
edited
Loading

Description

The markdown code in a draft release isn't properly rendered at the releaes list.

On https://try.gitea.io/viceice/test/releases i get a 500 when try to view the draft release page

Screenshots

image
image
@viceice viceice changed the title Draft mrakdown isn't redered on release list Draft markdown isn't redered on release list Aug 3, 2021
@lafriks lafriks added type/bug topic/ui Change the appearance of the Gitea UI labels Aug 3, 2021
@zeripath
Copy link
Contributor

zeripath commented Aug 5, 2021

I have a feeling that this has already been fixed by #15175 in 1.15+. Please try on 1.15.0-rc2 (or 1.15.0-rc3 as soon as that's out.)

The 500 is of more interest to me - Could you explain exactly how you get this? Please could you duplicate on 1.15 and give us some logs?

@viceice
Copy link
Contributor Author

viceice commented Aug 5, 2021

The 500 is happening on your try gitea page linked above.

Yes i think this is already fixed in v1.15 because I can't reproduce on try gitea.

@zeripath
Copy link
Contributor

zeripath commented Aug 5, 2021

Ah found it.

zeripath added a commit to zeripath/gitea that referenced this issue Aug 5, 2021
@zeripath
Prevent 500 on draft releases without tag
cdeb962 
It is possible to create draft releases prior to creating a tag. This will cause a
500 on the releases page due to compare page failing.

This PR only shows the compare button if there is a SHA1 present.

Fix go-gitea#16610

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Aug 5, 2021
Merged
@zeripath
Copy link
Contributor

zeripath commented Aug 5, 2021

I think there's another bug with the compare but I need to do more testing to check it.

techknowlogick added a commit that referenced this issue Aug 6, 2021
@zeripath @lafriks @techknowlogick
Prevent 500 on draft releases without tag (#16634)
067d82b 
It is possible to create draft releases prior to creating a tag. This will cause a
500 on the releases page due to compare page failing.

This PR only shows the compare button if there is a SHA1 present.

Fix #16610

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
techknowlogick added a commit to techknowlogick/gitea that referenced this issue Aug 6, 2021
@zeripath @lafriks @techknowlogick
Prevent 500 on draft releases without tag (go-gitea#16634)
271ba75 
It is possible to create draft releases prior to creating a tag. This will cause a
500 on the releases page due to compare page failing.

This PR only shows the compare button if there is a SHA1 present.

Fix go-gitea#16610

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@techknowlogick techknowlogick mentioned this issue Aug 6, 2021
Merged
lafriks added a commit that referenced this issue Aug 6, 2021
@techknowlogick @zeripath @lafriks
Prevent 500 on draft releases without tag (#16634) (#16636)
20601f8 
It is possible to create draft releases prior to creating a tag. This will cause a
500 on the releases page due to compare page failing.

This PR only shows the compare button if there is a SHA1 present.

Fix #16610

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lauris BH <lauris@nix.lv>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent 500 on draft releases without tag zeripath/gitea
3 participants
@lafriks @viceice @zeripath