Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor UI tweaks #5782

Closed
10 tasks
Larivact opened this issue Jan 20, 2019 · 1 comment
Closed
10 tasks

Minor UI tweaks #5782

Larivact opened this issue Jan 20, 2019 · 1 comment
Labels
topic/ui Change the appearance of the Gitea UI
Milestone
1.8.0

Comments

@Larivact
Copy link

Larivact commented Jan 20, 2019 •
edited
Loading

  • Gitea version (or commit ref): 1.7.0

Behavior

  • templates/repo/create.tmpl – Once you select a license you can no longer deselect it.
  • External issue trackers: The issues tab should have an external-link-alt icon and link directly to the external tracker so that you can see the URL by hovering over it.
  • When you select an issue/pull request the toggle button transitions to open & close buttons, which is not only problematic because it still looks like a toggle button but also doesn't make sense because you are never able to open or close an issue/pull request, it's either open or closed, you only ever have one choice (to toggle the current state). I suggest the transition to be removed and instead display an open or close button next to the toggle button.

    select_issue
  • The above check boxes should not be displayed for repositories where you are not allowed to open or close issues/pull requests.
  • 404 pages of files, issues, pull requests, releases and wiki pages should include the repository header if the repository exists.
  • Reset password should directly tell you when a code is invalid: https://try.gitea.io/user/reset_password?code=x
  • public/js/index.js – When editing the labels of an existing issue (see screenshot), the labels are currently saved with every select / deselect, which just leads to unnecessary spam. The labels should only be saved after closing the popup, which is also the way GitHub does it.
    label_popup

Visuals

  • templates/repo/header.tmpl – Visually disable fork button on own repositories (you cannot clone them) by adding disabled class .

    disable_fork
  • templates/repo/home.tmpl – Give New Pull Request button a text label instead of a cryptic icon.
    pull-button
  • public/less/themes/arc-green.less – The dark theme should use a less vibrant color for green buttons, I suggest #87ab63, the same color used for links.
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Jan 20, 2019
@Larivact Larivact mentioned this issue Jan 26, 2019
Closed
@jolheiser
Copy link
Member

jolheiser commented Feb 6, 2019 •
edited
Loading

I think I'll give this a go. I'll make a WIP PR once I've made some progress.

EDIT: The PR can be followed at #5980

jolheiser added a commit to jolheiser/gitea that referenced this issue Feb 10, 2019
@jolheiser
Minor UI tweaks (go-gitea#5782)
c13cd91 
Added 'No License' option
Added link and octicon change for external issue trackers
Reset password now notifies right away if the code is invalid

Signed-off-by: jolheiser <john.olheiser@gmail.com>
jolheiser added a commit to jolheiser/gitea that referenced this issue Feb 10, 2019
@jolheiser
Commit to reference related issues
1e7efd3 
Resolves go-gitea#5782
Resolves go-gitea#5861
Addresses original question in go-gitea#5993
@0x5c 0x5c mentioned this issue Feb 19, 2019
Merged
10 tasks
@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 19, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.8.0
Development

No branches or pull requests
4 participants
@lunny @techknowlogick @Larivact @jolheiser