Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix milestone API state parameter unhandled (#10049) #10053

Merged
merged 2 commits into from
Jan 30, 2020
Merged

Fix milestone API state parameter unhandled (#10049) #10053

merged 2 commits into from
Jan 30, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 29, 2020

backport from #10049

  • Fix milestone API state parameter unhandled
  • Fix test

@lunny
Fix milestone API state parameter unhandled (go-gitea#10049)
b5c3d79 
* Fix milestone API state parameter unhandled

* Fix test
@lunny lunny added the type/bug label Jan 29, 2020
@lunny lunny added this to the 1.10.4 milestone Jan 29, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 29, 2020
lafriks
lafriks reviewed Jan 29, 2020
View reviewed changes
integrations/api_issue_milestone_test.go Outdated
)

func TestAPIIssuesMilestone(t *testing.T) {
defer prepareTestEnv(t)()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be changed to what it was in v1.10

6543
6543 requested changes Jan 29, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per lafriks comment on test

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 30, 2020
@lunny lunny merged commit 0c5e2e2 into go-gitea:release/v1.10 Jan 30, 2020
@lunny lunny deleted the lunny/fix_milestone_api3 branch January 30, 2020 03:49
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.10.4
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @lafriks @6543 @GiteaBot