-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent DeleteUser API abuse #10125
Prevent DeleteUser API abuse #10125
Conversation
I think we should backport this ... |
I run in this trap while writing tests for the sdk ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nits otherwise LGTM
Codecov Report
@@ Coverage Diff @@
## master #10125 +/- ##
=========================================
Coverage ? 43.4%
=========================================
Files ? 576
Lines ? 79636
Branches ? 0
=========================================
Hits ? 34565
Misses ? 40791
Partials ? 4280
Continue to review full report at Codecov.
|
Please send backport |
* fix & co * word suggestions from @jolheiser
done -> #10128 |
* fix & co * word suggestions from @jolheiser
I think it's better to move the check into |
should I send a refactor PR? |
So orgs can't be deleted ever? 🤔 |
@guillep2k Orgs have there own delete function: Lines 257 to 275 in b3c72a7
to be exact it is here: Lines 299 to 301 in b3c72a7
|
close #10119