Cron job to cleanup hook_task table #13080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hooktask # Conflicts: # custom/conf/app.example.ini
|
unit test failed |
GiteaBot
added
the
lgtm/need 2
Codecov Report
@@ Coverage Diff @@
## master #13080 +/- ##
==========================================
+ Coverage 42.09% 42.11% +0.01%
==========================================
Files 758 758
Lines 81014 81080 +66
==========================================
+ Hits 34104 34147 +43
- Misses 41342 41357 +15
- Partials 5568 5576 +8
Continue to review full report at Codecov.
|
@lafriks I believe I have them passing now |
|
Please resolve conflicts |
…hooktask # Conflicts: # custom/conf/app.example.ini # docs/content/doc/advanced/config-cheat-sheet.en-us.md
@lafriks sure, I resolved them |
zeripath
approved these changes
Oct 27, 2020
GiteaBot
added
lgtm/need 1
|
Please fix the lint. |
it is passing the linter now, thanks |
6543
approved these changes
Jan 26, 2021
GiteaBot
added
lgtm/done
a1012112796
added a commit
to a1012112796/gitea
that referenced
this pull request
Jan 27, 2021
* master: [skip ci] Updated translations via Crowdin Fix bug because of duplicated join (go-gitea#14454) Cron job to cleanup hook_task table (go-gitea#13080) Fix panic 500 page rendering (go-gitea#14474) [skip ci] Updated translations via Crowdin Move macaron to chi (go-gitea#14293) [skip ci] Updated translations via Crowdin Fix incorrect key name so registerManualConfirm setting works as expected. (go-gitea#14455)
a1012112796
added a commit
to a1012112796/gitea
that referenced
this pull request
Jan 27, 2021
* master: [skip ci] Updated translations via Crowdin Fix bug because of duplicated join (go-gitea#14454) Cron job to cleanup hook_task table (go-gitea#13080) Fix panic 500 page rendering (go-gitea#14474) [skip ci] Updated translations via Crowdin Move macaron to chi (go-gitea#14293) [skip ci] Updated translations via Crowdin Fix incorrect key name so registerManualConfirm setting works as expected. (go-gitea#14455)
a1012112796
added a commit
to a1012112796/gitea
that referenced
this pull request
Jan 27, 2021
* master: [skip ci] Updated translations via Crowdin Fix bug because of duplicated join (go-gitea#14454) Cron job to cleanup hook_task table (go-gitea#13080) Fix panic 500 page rendering (go-gitea#14474) [skip ci] Updated translations via Crowdin Move macaron to chi (go-gitea#14293)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref issue: #10741
Added a cron job to delete webhook deliveries in the hook_task table. It can be turned on/off and the schedule controlled globally via app.ini. The data can be deleted by either the age of the delivery which is the default or by deleting the all but the most recent deliveries per webhook.
Note: I had previously submitted pr #11416 but I closed it when I realized that I had deleted per repository instead of per webhook. Also, I decided allowing the settings to be overridden via the ui was overkill. Also this version allows the deletion by age which is probably what most people would want.