Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the logger an interface #13294

Merged
merged 3 commits into from
Oct 31, 2020
Merged

Conversation

zeripath
Copy link
Contributor

Extracted from #12264

Refactor Logger to make a logger interface and make it possible to
wrap loggers for specific purposes.

Refactor Logger to make a logger interface and make it possible to
wrap loggers for specific purposes.
@zeripath zeripath added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Oct 24, 2020
@zeripath zeripath added this to the 1.14.0 milestone Oct 24, 2020
modules/log/logger.go Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 24, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 31, 2020
@codecov-io
Copy link

Codecov Report

Merging #13294 into master will decrease coverage by 0.02%.
The diff coverage is 57.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13294      +/-   ##
==========================================
- Coverage   42.15%   42.12%   -0.03%     
==========================================
  Files         690      691       +1     
  Lines       75888    75909      +21     
==========================================
- Hits        31987    31974      -13     
- Misses      38663    38694      +31     
- Partials     5238     5241       +3     
Impacted Files Coverage Δ
models/log.go 36.58% <ø> (ø)
modules/indexer/code/elastic_search.go 1.76% <ø> (ø)
modules/log/colors.go 71.23% <ø> (-1.37%) ⬇️
modules/log/level.go 72.50% <0.00%> (-12.80%) ⬇️
modules/log/logger.go 10.52% <8.33%> (-52.86%) ⬇️
modules/log/log.go 58.08% <60.00%> (ø)
modules/log/multichannel.go 87.50% <87.50%> (ø)
modules/indexer/issues/elastic_search.go 67.21% <100.00%> (ø)
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c32367...5d104b1. Read the comment docs.

@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 47dd1cb into go-gitea:master Oct 31, 2020
@zeripath zeripath deleted the refactor-logger branch October 31, 2020 09:36
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants