Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change search and filter icons to SVG #13473

Merged
merged 2 commits into from
Nov 9, 2020
Merged

Change search and filter icons to SVG #13473

merged 2 commits into from
Nov 9, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Nov 8, 2020 •
edited
Loading

Unfortunately, the Fomantic CSS relies on i.icon instead of .icon so a wrapper is necessary.

Screen Shot 2020-11-08 at 21 45 54

Screen Shot 2020-11-08 at 21 30 43

Screen Shot 2020-11-08 at 21 31 28

Screen Shot 2020-11-08 at 21 45 38

@silverwind silverwind force-pushed the searchicons branch 2 times, most recently from 2770e3b to f61d239 Compare November 8, 2020 20:53
@silverwind
Change search and filter icons to SVG
b4c39e8 
Unfortunately, the Fomantic CSS relies on i.icon instead of .icon so a
wrapper is necessary for these with an accompanying class to center the
icon.
@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Nov 8, 2020
@techknowlogick techknowlogick added this to the 1.14.0 milestone Nov 8, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 9, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 9, 2020
@zeripath zeripath merged commit 8bae34c into go-gitea:master Nov 9, 2020
@silverwind silverwind deleted the searchicons branch November 9, 2020 20:43
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
6 participants
@silverwind @lafriks @mrsdizzie @techknowlogick @zeripath @GiteaBot