Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Admin EditUser: Make FullName, Email, Website & Location optional #13562

Merged
merged 5 commits into from
Nov 20, 2020
Merged

API: Admin EditUser: Make FullName, Email, Website & Location optional #13562

merged 5 commits into from
Nov 20, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 14, 2020 •
edited
Loading

make more values optional for Admin EditUser

close #13543

@6543 6543 mentioned this pull request Nov 14, 2020
Closed
6 tasks
@6543 6543 added this to the 1.14.0 milestone Nov 14, 2020
@6543 6543 added modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality labels Nov 14, 2020
@codecov-io
Copy link

codecov-io commented Nov 14, 2020 •
edited
Loading

Codecov Report

Merging #13562 (083b0f5) into master (24b3b21) will increase coverage by 0.02%.
The diff coverage is 41.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13562      +/-   ##
==========================================
+ Coverage   42.19%   42.22%   +0.02%     
==========================================
  Files         697      697              
  Lines       76582    76589       +7     
==========================================
+ Hits        32312    32337      +25     
+ Misses      38968    38936      -32     
- Partials     5302     5316      +14
Impacted Files Coverage Δ
routers/api/v1/admin/user.go 35.97% <41.66%> (+5.40%) ⬆️
services/pull/pull.go 40.78% <0.00%> (ø)
models/user.go 54.57% <0.00%> (+0.20%) ⬆️
modules/log/event.go 59.90% <0.00%> (+0.94%) ⬆️
services/pull/patch.go 55.68% <0.00%> (+1.70%) ⬆️
services/pull/check.go 51.82% <0.00%> (+2.91%) ⬆️
services/pull/temp_repo.go 29.78% <0.00%> (+3.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24b3b21...083b0f5. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 14, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 15, 2020
6543
6543 commented Nov 15, 2020
View reviewed changes
routers/api/v1/admin/user.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 15, 2020
@6543 6543 added the pr/wip This PR is not ready for review label Nov 16, 2020
@6543 6543 force-pushed the api_admin-edit-user_optional-values branch from d5cd157 to eb5e788 Compare November 19, 2020 14:30
@6543 6543 removed the pr/wip This PR is not ready for review label Nov 19, 2020
@6543
Copy link
Member Author

6543 commented Nov 19, 2020

@lafriks done + added test to ensure it

@6543 6543 requested a review from lafriks November 19, 2020 15:31
@6543
Copy link
Member Author

6543 commented Nov 20, 2020

🚀

@techknowlogick techknowlogick merged commit 1bb5c09 into go-gitea:master Nov 20, 2020
@6543 6543 deleted the api_admin-edit-user_optional-values branch November 20, 2020 01:57
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny left review comments

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

API Call /admin/users/{username} does not work without email.
7 participants
@6543 @codecov-io @lunny @lafriks @zeripath @techknowlogick @GiteaBot