Refactor combine label comments with tests #13619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
|
thanks, i'm testing |
GiteaBot
added
the
lgtm/need 2
|
@lunny work fine for me and fix my issue. can you merge it and create docker tag for latest ? |
6543
approved these changes
Nov 20, 2020
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Nov 20, 2020
GiteaBot
added
lgtm/done
|
🚀 |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May fix #13516 but I cannot confirm that. @vtolstov maybe you could help to confirm?
There is an regression that this PR will not remove the labels which will be in both addedlabels and removedlabels. I don't know how Github handles this situation, but I think it's more clear to keep them even if it's a mistake of the poster.