Swap swagger-ui with swagger-ui-dist #13777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prebuilt version of swagger-ui is identical to the regular one but brings the benefit of faster webpack compilation and less npm dependencies so it npm installs will speed up too.
techknowlogick
added
type/refactoring
|
Interestingly webpack was a minute slower this run, will test locally. |
GiteaBot
added
the
lgtm/need 2
|
Ok, build speed and output size back to normal. I don't really see a webpack speed improvement but I guess dropping 111 npm dependencies is still a net gain overall. |
6543
approved these changes
Dec 1, 2020
GiteaBot
added
lgtm/need 1
6543
added
dependencies
and removed
topic/ui
techknowlogick
approved these changes
Dec 2, 2020
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prebuilt version of swagger-ui is identical to the regular one but brings the benefit of faster webpack compilation and less npm dependencies.