Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Generate man pages #13901

Merged
merged 11 commits into from
Feb 24, 2021
Merged

[Docs] Generate man pages #13901

merged 11 commits into from
Feb 24, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Dec 8, 2020

close #11476
fix #11399

@6543 6543 added type/docs This PR mainly updates/creates documentation pr/wip This PR is not ready for review labels Dec 8, 2020
@6543 6543 changed the title Docs man pages [Docs] generate man pages Dec 8, 2020
@6543 6543 marked this pull request as ready for review December 8, 2020 16:53
@6543
Copy link
Member Author

6543 commented Dec 8, 2020

@bagasme would you like to have a look at it

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 8, 2020
@jolheiser
Copy link
Member

This should probably leverage the existing docs command with the man flag.

@codecov-io
Copy link

codecov-io commented Dec 8, 2020

Codecov Report

Merging #13901 (ed31084) into master (487f2ee) will decrease coverage by 0.00%.
The diff coverage is 42.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13901      +/-   ##
==========================================
- Coverage   42.21%   42.21%   -0.01%     
==========================================
  Files         767      771       +4     
  Lines       81624    82068     +444     
==========================================
+ Hits        34458    34641     +183     
- Misses      41531    41779     +248     
- Partials     5635     5648      +13     
Impacted Files Coverage Δ
models/migrations/migrations.go 2.59% <ø> (ø)
models/migrations/v166.go 0.00% <0.00%> (ø)
models/migrations/v172.go 0.00% <0.00%> (ø)
models/migrations/v173.go 0.00% <0.00%> (ø)
models/session.go 0.00% <0.00%> (ø)
models/user.go 53.05% <ø> (+0.38%) ⬆️
modules/context/context.go 58.05% <0.00%> (-0.45%) ⬇️
modules/indexer/code/elastic_search.go 1.72% <0.00%> (-0.02%) ⬇️
modules/migrations/github.go 77.77% <0.00%> (-1.99%) ⬇️
modules/session/virtual.go 60.20% <0.00%> (-1.26%) ⬇️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3e64f6...ed31084. Read the comment docs.

@6543 6543 removed the pr/wip This PR is not ready for review label Jan 19, 2021
@6543 6543 added this to the 1.14.0 milestone Jan 19, 2021
@lunny
Copy link
Member

lunny commented Feb 18, 2021

Is this ready to review?

@6543
Copy link
Member Author

6543 commented Feb 19, 2021

@lunny sure - for the whole time

Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider leverage the existing docs command with the man flag.

@6543 6543 removed this from the 1.14.0 milestone Feb 19, 2021
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Feb 24, 2021

@jolheiser removed it and just leave a TODO back there ...

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 24, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 24, 2021
@jolheiser jolheiser merged commit 5cc1a49 into go-gitea:master Feb 24, 2021
@6543 6543 deleted the docs_man-pages branch February 24, 2021 22:40
@6543 6543 added this to the 1.14.0 milestone Feb 24, 2021
@6543 6543 changed the title [Docs] generate man pages [Docs] Generate man pages Feb 24, 2021
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Writing Manpage
6 participants