Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Add Ref to Issue #13946

Merged
merged 6 commits into from
Dec 13, 2020

Conversation

zeripath
Copy link
Contributor

This PR adds Ref to api.Issue and adds the backend parts to the migrator.

Fix #13918

Signed-off-by: Andrew Thornton art27@cantab.net

This PR adds Ref to api.Issue and adds the backend parts to the migrator.

Fix go-gitea#13918

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/feature Completely new functionality. Can only be merged if feature freeze is not active. topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them labels Dec 11, 2020
@zeripath zeripath added this to the 1.14.0 milestone Dec 11, 2020
@zeripath
Copy link
Contributor Author

@6543 we would need to add support to the gitea SDK and then back here to make this migratable.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 11, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 11, 2020
@6543
Copy link
Member

6543 commented Dec 11, 2020

@6543 6543 added modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Dec 11, 2020
@6543 6543 changed the title Add Ref to api.Issue [API] Add Ref to Issue Dec 11, 2020
@6543
Copy link
Member

6543 commented Dec 11, 2020

@zeripath make generate-swagger ...

@codecov-io
Copy link

codecov-io commented Dec 12, 2020

Codecov Report

Merging #13946 (c13e47c) into master (de0986d) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13946      +/-   ##
==========================================
- Coverage   42.21%   42.20%   -0.01%     
==========================================
  Files         710      710              
  Lines       77230    77232       +2     
==========================================
- Hits        32601    32595       -6     
- Misses      39256    39262       +6     
- Partials     5373     5375       +2     
Impacted Files Coverage Δ
modules/migrations/gitea_uploader.go 6.71% <0.00%> (-0.02%) ⬇️
modules/structs/issue.go 0.00% <ø> (ø)
modules/convert/issue.go 87.40% <100.00%> (+0.09%) ⬆️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
services/pull/check.go 48.90% <0.00%> (-2.19%) ⬇️
modules/git/repo.go 45.72% <0.00%> (-0.51%) ⬇️
models/error.go 38.49% <0.00%> (-0.49%) ⬇️
models/issue_comment.go 52.71% <0.00%> (-0.16%) ⬇️
services/pull/pull.go 41.17% <0.00%> (+0.49%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf6f8b2...c13e47c. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 13, 2020
@zeripath zeripath merged commit 825efa2 into go-gitea:master Dec 13, 2020
@zeripath zeripath deleted the fix-13918-add-ref-to-api.Issue branch December 13, 2020 11:34
@6543
Copy link
Member

6543 commented Dec 15, 2020

@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API endpoints not returning issue tag/branch
5 participants