Disable SSH key deletion of externally managed Keys

[zeripath]

When a user has a login source which has SSH key management
deletion of keys from that source using the UI should be disabled.

Fix #13983

Signed-off-by: Andrew Thornton art27@cantab.net

[silverwind]

Is it breaking? What happens to existing gitea-local keys that were previously added? Do they become unremovable?

[zeripath]

Oh crap I've just realised that I missed something - the keys do actually have a login_source.

[codecov-io]

Codecov Report

Merging #13985 (a6b2543) into master (e0c753e) will decrease coverage by 0.13%.
The diff coverage is 39.43%.

@@            Coverage Diff             @@
##           master   #13985      +/-   ##
==========================================
- Coverage   42.37%   42.24%   -0.14%     
==========================================
  Files         726      726              
  Lines       77839    77908      +69     
==========================================
- Hits        32982    32909      -73     
- Misses      39447    39579     +132     
- Partials     5410     5420      +10     

Impacted Files	Coverage Δ
routers/user/setting/keys.go	11.11% <13.33%> (+0.31%)	⬆️
routers/api/v1/user/key.go	53.39% <28.57%> (-1.25%)	⬇️
models/ssh_key.go	46.52% <48.97%> (+0.16%)	⬆️
modules/log/stack.go	0.00% <0.00%> (-81.82%)	⬇️
modules/log/conn.go	3.50% <0.00%> (-78.95%)	⬇️
modules/log/logger.go	0.00% <0.00%> (-10.53%)	⬇️
modules/log/event.go	50.00% <0.00%> (-9.91%)	⬇️
modules/git/tree_entry_nogogit.go	87.50% <0.00%> (-6.25%)	⬇️
modules/repofiles/tree.go	76.27% <0.00%> (-5.09%)	⬇️
modules/queue/manager.go	62.13% <0.00%> (-2.96%)	⬇️
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0c753e...a6b2543. Read the comment docs.

[zeripath]

Lets try again - this time the buttons are disabled if the key is an externally managed key

[strk]

LGTM (not tested). I think for our goal we'll just drop all buttons and replace with a single button to direct users to the LDAP user management external url, which would still require a custom template, but it's good that there's no risk of some commandline tool removing externally managed keys

[techknowlogick]

🚀