Inline manifest.json

[silverwind]

Improve performance by eliminating this separate request and just inline this small JSON in HTML directly as a data uri. Also, I've updated the previously static app name scripts to use AppName from config. theme_color is removed because it's duplicating with the existing meta tag.

I've confirmed this as working via "Add to Homescreen" feature which offered to save the shortcut under the new app name.

[zeripath]

Is the data uri always going to work?

[silverwind]

Yes, browsers are required to implement data URIs if they want to conform HTML5.

We just need to be careful with data emitted in the string because it must be URL-escaped. I guess StaticUrlPrefix and AppSubUrl should generally only contain URL-safe characters but I guess we could also just escape them.

[silverwind]

Okay everything is escaped now including the URLs. Browsers will URL-decode the string before parsing it is it's safe to do in all cases.

[techknowlogick]

This change seems unrelated, could you describe why this is being removed?

[silverwind]

I's becoming unused because the /manifest.json route was the only consumer of the variable (I added it with the HTTP cache commit). We can keep it around if you prefer.

[a1012112796]

Hmm, I think it's duplicate with this line also.

gitea/routers/admin/admin.go

Line 43 in 4aabbac

startTime = time.Now()

[silverwind]

I've restored setting.AppStartTime and it's now being used on the admin page:

[zeripath]

Is it possible keep the file but insert its contents directly into the attribute?

That way you can keep the endpoint around for those who don't update their templates

[silverwind]

Can't insert the JSON as-is because it needs URL escaping and I'm generally leaning to not do that kind of extra processing for the sake of performance.

What is the issue exactly about people not updating their templates? I thought templates work by the way of inserting user content at strategic places in the HTML. How come a user would have these parts hardcoded in their template customization?

[lunny]

It could be put in bindata and load on template rendering if necessary.

[silverwind]

I was thinking about generating it once on app startup and caching it in memory for even more speed, thought I guess the gains would be minimal.

[lunny]

Please resolve the conflicts.

[wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf]

What is the issue exactly about people not updating their templates? I thought templates work by the way of inserting user content at strategic places in the HTML. How come a user would have these parts hardcoded in their template customization?

I am keeping around a custom template.
What exactly would I have to update in my pwa/manifest_json.tmpl to make it work once this is merged?
From what I gathered I should be ok :D

[silverwind]

Ah, so you are customizing the "private" templates, didn't know that was possible.

You can just delete it, it doesn't exist anymore after this change.

[wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf]

Ah, so you are customizing the "private" templates, didn't know that was possible.

You can just delete it, it doesn't exist anymore after this change.

well that's too bad because I'm doing a little customization in there, such as using relative /img references.

[lunny]

Ah, so you are customizing the "private" templates, didn't know that was possible.
You can just delete it, it doesn't exist anymore after this change.

well that's too bad because I'm doing a little customization in there, such as using relative /img references.

I think you could find other way to do that on Gitea.

[wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf]

Ah, so you are customizing the "private" templates, didn't know that was possible.
You can just delete it, it doesn't exist anymore after this change.

well that's too bad because I'm doing a little customization in there, such as using relative /img references.

I think you could find other way to do that on Gitea.

yeah, the expression will have to be replaced on the proxy.