Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate building for mips #14174

Merged
merged 2 commits into from
Jan 1, 2021

Conversation

techknowlogick
Copy link
Member

as title

@techknowlogick techknowlogick added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Dec 28, 2020
@techknowlogick techknowlogick added this to the 1.14.0 milestone Dec 28, 2020
@codecov-io
Copy link

Codecov Report

Merging #14174 (6a26dca) into master (3175d08) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14174      +/-   ##
==========================================
- Coverage   42.01%   42.01%   -0.01%     
==========================================
  Files         733      733              
  Lines       78704    78704              
==========================================
- Hits        33070    33065       -5     
- Misses      40202    40205       +3     
- Partials     5432     5434       +2     
Impacted Files Coverage Δ
modules/git/repo_base_nogogit.go 63.63% <0.00%> (-9.10%) ⬇️
modules/indexer/stats/db.go 48.00% <0.00%> (-8.00%) ⬇️
modules/git/utils.go 77.77% <0.00%> (-2.78%) ⬇️
services/pull/pull.go 42.35% <0.00%> (-0.51%) ⬇️
modules/process/manager.go 75.00% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 366ce66...6a26dca. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 28, 2020
@zeripath
Copy link
Contributor

how comes?

@techknowlogick
Copy link
Member Author

@zeripath a grep of our logs from dl.gitea.io shows that it isn't being downloaded, and the downloads from github (https://somsubhra.com/github-release-stats/?username=go-gitea&repository=gitea) show that the number minimal, could even be bots.

It'll also reduce our release step build time, as it would be 3 less cross-compiles needed

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 1, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 1, 2021
@lunny
Copy link
Member

lunny commented Jan 1, 2021

We may also mentioned this on docs.

@lunny lunny added the type/changelog Adds the changelog for a new Gitea version label Jan 1, 2021
@lunny lunny merged commit 4f2f08b into go-gitea:master Jan 1, 2021
@techknowlogick techknowlogick deleted the techknowlogick-patch-3 branch January 1, 2021 17:52
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
@delvh delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants