Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle NotifyCreateRef as create branch in feeds #14245

Merged
merged 2 commits into from
Jan 4, 2021

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented Jan 4, 2021

A rather ugly workaround for the fact that NotifyCreateRef must use ActionCommitRepo.

This is basically how everyone else has to deal with it for webhooks (which follow how GH does it) to catch 'create branch' event.

Avoids having two 'pushed to {{branch}}` actions, one empty and another with actual commits, on dashboard feeds.

@codecov-io
Copy link

Codecov Report

Merging #14245 (675221e) into master (21fbee1) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14245   +/-   ##
=======================================
  Coverage   41.96%   41.97%           
=======================================
  Files         735      735           
  Lines       78933    78933           
=======================================
+ Hits        33126    33131    +5     
+ Misses      40350    40347    -3     
+ Partials     5457     5455    -2     
Impacted Files Coverage Δ
models/error.go 38.49% <0.00%> (-0.49%) ⬇️
modules/log/event.go 59.90% <0.00%> (+0.94%) ⬆️
modules/git/batch_reader_nogogit.go 46.26% <0.00%> (+1.49%) ⬆️
modules/indexer/stats/db.go 52.00% <0.00%> (+4.00%) ⬆️
modules/git/repo_language_stats_nogogit.go 63.82% <0.00%> (+6.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21fbee1...675221e. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 4, 2021
@a1012112796 a1012112796 added type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality. and removed type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Jan 4, 2021
@lafriks lafriks added this to the 1.14.0 milestone Jan 4, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 4, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 4, 2021
@lafriks
Copy link
Member

lafriks commented Jan 4, 2021

🚀

@lafriks lafriks merged commit 8db0372 into go-gitea:master Jan 4, 2021
@CirnoT CirnoT deleted the create-branch branch January 5, 2021 09:04
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants