Disable Stars config option

[kdumontnu]

If DISABLE_STARS = true remove the option to star repositories

The "Starred Repositories" tab in user profile is replaced with "Watched Repositories"

This is helpful for enterprise/private accounts where the ability to "star" repositories is not very useful and creates confusion compared to "watching".

Note: I'm working on a separate PR to toggle Watch status in the Profile repo list

[6543]

I think the "watching repos" is a nice func anyway :) ... just if we going to add it, can we add a prifacy opt-out add too?

like it exist for Hide the activity from the profile page

[kdumontnu]

I think the "watching repos" is a nice func anyway :) ... just if we going to add it, can we add a prifacy opt-out add too?

like it exist for Hide the activity from the profile page

I used the same settings as "Starred Repositories". Should that be hidden as well? The setting is also ignored for Repositories, Following, and Followed. This seems like a separate PR, but I'm happy to open one to fix that.

[codecov-io]

Codecov Report

Merging #14653 (2638218) into master (487f2ee) will decrease coverage by 0.00%.
The diff coverage is 34.28%.

@@            Coverage Diff             @@
##           master   #14653      +/-   ##
==========================================
- Coverage   42.21%   42.21%   -0.01%     
==========================================
  Files         767      767              
  Lines       81624    81652      +28     
==========================================
+ Hits        34458    34468      +10     
- Misses      41531    41547      +16     
- Partials     5635     5637       +2     

Impacted Files	Coverage Δ
models/repo_list.go	77.19% <0.00%> (-1.57%)	⬇️
modules/setting/repository.go	57.69% <ø> (ø)
modules/structs/issue.go	0.00% <ø> (ø)
routers/user/profile.go	43.24% <0.00%> (-4.05%)	⬇️
modules/queue/unique_queue_disk_channel.go	55.22% <50.00%> (+1.37%)	⬆️
modules/context/context.go	58.61% <100.00%> (+0.10%)	⬆️
modules/setting/setting.go	49.03% <100.00%> (ø)
modules/templates/base.go	42.30% <100.00%> (+1.13%)	⬆️
routers/api/v1/settings/settings.go	100.00% <100.00%> (ø)
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f05a28...8bf3a61. Read the comment docs.

[kdumontnu]

@6543 did you still want me to make the change to put this behind the KeepActivityPrivate flag?
It appears right now this flag is only checked for the Activity tab, not Repositories, Stars, Following, or Followed.
I'm happy to make the change, but honestly I think it's better to do in a separate PR to address all cases.

[6543]

@kdumontnu I think we can seperate it ...

[6543]

@kdumontnu sorry that it wont get reviewed and merged right away... just for you as an info: gitea is in feature freeze at the moment ...

[zeripath]

OK I think this looks fine - I don't quite understand why the feature needs disabling but the PR does do everything needed to disable the feature completely.

[kdumontnu]

OK I think this looks fine - I don't quite understand why the feature needs disabling but the PR does do everything needed to disable the feature completely.

Excellent! I understand the hesitation, but generally speaking for private projects "stars" provide very little value and can add unnecessary complexity for users.

[techknowlogick]

@kdumontnu just reaching out to you here to let you know I sent a PM to your discord, hoping you saw it :)

[zeripath]

Please resolve conflicts

[6543]

@kdumontnu can you "update branch" please?

[6543]

🚀