Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migration context data #14910

Merged
merged 3 commits into from
Mar 7, 2021
Merged

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Mar 6, 2021

The migration page misses some context data if an error occurs.

Without error:
grafik

With error:
grafik

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 6, 2021
routers/repo/migrate.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 7, 2021
@6543 6543 added the type/bug label Mar 7, 2021
@6543 6543 added this to the 1.14.0 milestone Mar 7, 2021
@codecov-io
Copy link

Codecov Report

Merging #14910 (dac3a02) into master (9b261f5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14910      +/-   ##
==========================================
- Coverage   42.13%   42.13%   -0.01%     
==========================================
  Files         774      774              
  Lines       82905    82906       +1     
==========================================
- Hits        34932    34930       -2     
  Misses      42298    42298              
- Partials     5675     5678       +3     
Impacted Files Coverage Δ
routers/repo/migrate.go 40.42% <100.00%> (+0.42%) ⬆️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
services/pull/pull.go 41.60% <0.00%> (-0.49%) ⬇️
models/unit.go 49.31% <0.00%> (+2.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b261f5...dac3a02. Read the comment docs.

@6543 6543 merged commit 40aca73 into go-gitea:master Mar 7, 2021
@KN4CK3R KN4CK3R deleted the fix-migrate-context-data branch March 16, 2021 15:38
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants