Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment of People and Teams right arrow on org homepage #14924

Merged

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Mar 7, 2021

Fix #14854

Signed-off-by: Andrew Thornton art27@cantab.net

Fix go-gitea#14854

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/bug topic/ui Change the appearance of the Gitea UI labels Mar 7, 2021
@zeripath zeripath added this to the 1.14.0 milestone Mar 7, 2021
@zeripath
Copy link
Contributor Author

zeripath commented Mar 7, 2021

Also fixes the Cog on the Org title settings.

The sort arrow indicator is consistent across the rest of the application.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 7, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 8, 2021
@codecov-io
Copy link

Codecov Report

Merging #14924 (a819e3c) into master (487f2ee) will decrease coverage by 0.05%.
The diff coverage is 40.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14924      +/-   ##
==========================================
- Coverage   42.21%   42.16%   -0.06%     
==========================================
  Files         767      774       +7     
  Lines       81624    82919    +1295     
==========================================
+ Hits        34458    34962     +504     
- Misses      41531    42281     +750     
- Partials     5635     5676      +41     
Impacted Files Coverage Δ
cmd/dump.go 0.93% <0.00%> (-0.01%) ⬇️
cmd/serv.go 2.61% <0.00%> (-0.02%) ⬇️
cmd/web.go 0.00% <0.00%> (ø)
cmd/web_graceful.go 0.00% <0.00%> (ø)
cmd/web_letsencrypt.go 0.00% <0.00%> (ø)
models/action.go 48.52% <0.00%> (-2.42%) ⬇️
models/migrations/migrations.go 2.59% <ø> (ø)
models/migrations/v130.go 0.00% <0.00%> (ø)
models/migrations/v166.go 0.00% <0.00%> (ø)
models/migrations/v172.go 0.00% <0.00%> (ø)
... and 182 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c03f530...a819e3c. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 8, 2021
@6543
Copy link
Member

6543 commented Mar 8, 2021

🚀

@6543 6543 merged commit 6171114 into go-gitea:master Mar 8, 2021
@zeripath zeripath deleted the fix-14854-fix-position-of-buttons-org-home branch March 8, 2021 16:18
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Borked button alignment on organization page
7 participants