Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move repo.CloseIssuesViaCommitInAnyBranch to issue settings #14965

Merged
merged 3 commits into from
Mar 16, 2021

Conversation

noerw
Copy link
Member

@noerw noerw commented Mar 12, 2021

On the repo settings page, this setting was in the admin section (only available to siteadmins). Now it's in advanced, under the internal issue tracker section.
Looking at the commits in #5992 which introduced this, it looks very much like this choice was made by mistake, actually intending repo admins.

@noerw noerw added type/bug topic/ui Change the appearance of the Gitea UI and removed type/bug topic/ui Change the appearance of the Gitea UI labels Mar 12, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 12, 2021
@zeripath zeripath added type/bug topic/ui Change the appearance of the Gitea UI labels Mar 12, 2021
@zeripath zeripath added this to the 1.14.0 milestone Mar 12, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 15, 2021
@6543
Copy link
Member

6543 commented Mar 16, 2021

🚀

@6543 6543 merged commit f4629fc into go-gitea:master Mar 16, 2021
@6543 6543 deleted the fix-reposetting branch March 16, 2021 01:00
@6543 6543 mentioned this pull request Mar 18, 2021
1 task
@6543 6543 added type/enhancement An improvement of existing functionality and removed type/bug topic/ui Change the appearance of the Gitea UI labels Mar 18, 2021
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants