Move FCGI req.URL.Path fix-up to the FCGI listener #15292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the web.go FCGI path by moving the req.URL.Path fix-up to listener Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
the
type/refactoring
|
extract from #15186 |
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Apr 6, 2021
GiteaBot
added
lgtm/need 1
zeripath
added
type/bug
backport/v1.14
and removed
type/refactoring
|
Actually having tested on master - I think this is actually necessary to fix a bug with FCGI. |
lunny
approved these changes
Apr 9, 2021
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Apr 9, 2021
Backport go-gitea#15292 Simplify the web.go FCGI path by moving the req.URL.Path fix-up to listener Signed-off-by: Andrew Thornton <art27@cantab.net>
Merged
6543
approved these changes
Apr 9, 2021
GiteaBot
added
lgtm/done
zeripath
added a commit
that referenced
this pull request
Apr 9, 2021
zeripath
added a commit
that referenced
this pull request
May 4, 2021
…15301) Since the move to Chi the number of stack frames has proliferated somewhat catastrophically and we're up to 96 frames with multiple tests of the url outside of a trie which is inefficient. This PR reduces the number of stack frames by 6 through careful use of Route, moves Captcha into its own router so that it only fires on Captcha routes, similarly for avatars and repo-avatars. The robots.txt, / and apple-touch-icon.png are moved out of requiring Contexter. It moves access logger higher in the stack frame because there is no reason why it can't be higher. Extract from #15186 Contains #15292
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the web.go FCGI path by moving the req.URL.Path fix-up to listener. This makes FCGI work on SubURLs following the Chi migration.
Signed-off-by: Andrew Thornton art27@cantab.net