Keep attachments on tasklist update of issue and comment content #16762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nge checkbox state), ignore attachment updates
|
Oh, I pushed the same just moments ago #16763 |
GiteaBot
added
the
lgtm/need 2
Codecov Report
@@ Coverage Diff @@
## main #16762 +/- ##
==========================================
- Coverage 45.38% 45.35% -0.04%
==========================================
Files 760 760
Lines 85495 85495
==========================================
- Hits 38803 38774 -29
- Misses 40410 40436 +26
- Partials 6282 6285 +3
Continue to review full report at Codecov.
|
lafriks
approved these changes
Aug 21, 2021
GiteaBot
added
lgtm/need 1
This was referenced Aug 21, 2021
zeripath
approved these changes
Aug 21, 2021
GiteaBot
added
lgtm/done
KN4CK3R
pushed a commit
to KN4CK3R/gitea
that referenced
this pull request
Aug 21, 2021
…nge checkbox state), ignore attachment updates (go-gitea#16762)
zeripath
pushed a commit
that referenced
this pull request
Aug 21, 2021
* Send attachments too. * Use tasklist flag. * use action="ignoreAttachments" instead of "tasklist" * Use boolean parameter. * when the update request doesn't intend to update attachments (eg: change checkbox state), ignore attachment updates (#16762) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Codeberg-org
pushed a commit
to Codeberg-org/gitea
that referenced
this pull request
Aug 24, 2021
* Send attachments too. * Use tasklist flag. * use action="ignoreAttachments" instead of "tasklist" * Use boolean parameter. * when the update request doesn't intend to update attachments (eg: change checkbox state), ignore attachment updates (go-gitea#16762) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR about "Keep attachments on tasklist update": #16750 is incomplete. Related issue: #16746
The PR #16750 only patches the update of comment, but not the update of the issue, which make the bug still exist.
And I think the new logic is more clear, we should not just
returnwhenignore_attachments=true, which will bypass all remaining logic, may lead to problem in the future.