Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ParseQueueConnStr as it is unused #16878

Merged
merged 2 commits into from
Aug 31, 2021

Conversation

zeripath
Copy link
Contributor

Remove ParseQueueConnStr as modules/nosql has taken over all of its functions.

Signed-off-by: Andrew Thornton art27@cantab.net

Remove ParseQueueConnStr as `modules/nosql` has taken over all of its functions.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Aug 30, 2021
@zeripath zeripath added this to the 1.16.0 milestone Aug 30, 2021
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 30, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 30, 2021
@lunny
Copy link
Member

lunny commented Aug 30, 2021

Remove ParseQueueConnStr as modules/nosql has taken over all of its functions.

Signed-off-by: Andrew Thornton art27@cantab.net

Isn't an old configuration will be break here?

@zeripath
Copy link
Contributor Author

Remove ParseQueueConnStr as modules/nosql has taken over all of its functions.
Signed-off-by: Andrew Thornton art27@cantab.net

Isn't an old configuration will be break here?

Nope ToRedisURI handles all of that.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 31, 2021
@6543
Copy link
Member

6543 commented Aug 31, 2021

🚀

@6543 6543 merged commit f2b4b0f into go-gitea:main Aug 31, 2021
@zeripath zeripath deleted the remove-old-queue-settings branch August 31, 2021 06:33
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants