Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protection to disable Gitea when run as root #17168

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions modules/setting/setting.go
Original file line number Diff line number Diff line change
Expand Up @@ -898,6 +898,9 @@ func NewContext() {
}

RunUser = Cfg.Section("").Key("RUN_USER").MustString(user.CurrentUsername())
// The following an unsafe option, purposely left out of documentation. Please do not run Gitea as root. It will only cause future headaches.
techknowlogick marked this conversation as resolved.
Show resolved Hide resolved
// Please don't use root as a bandaid to "fix" something that is brokenn, instead the broken thing should instead be fixed properly.
techknowlogick marked this conversation as resolved.
Show resolved Hide resolved
UnsafeAllowRunAsRoot = Cfg.Section("").Key("I_AM_BEING_UNSAFE_RUNNING_AS_ROOT").MustBool(false)
RunMode = Cfg.Section("").Key("RUN_MODE").MustString("prod")
// Does not check run user when the install lock is off.
if InstallLock {
Expand All @@ -907,6 +910,14 @@ func NewContext() {
}
}

if RunUser == "root" && !UnsafeAllowRunAsRoot {
if !UnsafeAllowRunAsRoot {
// Special thanks to VLC which inspired the wording of this messaging.
6543 marked this conversation as resolved.
Show resolved Hide resolved
log.Fatal("Gitea is not supposed to be run as root. Sorry. If you need to use privileged TCP ports please instead use setcap and the `cap_net_bind_service` permission")
}
log.Warn("You are running Gitea using the root user, and have purposely chosen to skip built-in protections around this. You have been warned against this.")
6543 marked this conversation as resolved.
Show resolved Hide resolved
6543 marked this conversation as resolved.
Show resolved Hide resolved
}

SSH.BuiltinServerUser = Cfg.Section("server").Key("BUILTIN_SSH_SERVER_USER").MustString(RunUser)

newRepository()
Expand Down