Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong scopes caused by empty scope input #19029

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Fix wrong scopes caused by empty scope input #19029

merged 2 commits into from
Mar 8, 2022

Conversation

wxiaoguang
Copy link
Contributor

As the title, close #18972

Try to fix:

And there are many bugs in the admin login source page, they can not be fixed easily in this PR, so I just left some FIXMEs.

@wxiaoguang wxiaoguang added this to the 1.17.0 milestone Mar 8, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 8, 2022
noerw
noerw approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@noerw noerw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but shouldn't those FIXMEs be github issues? (ok it's arguable where the note will get lost more quickly 🙃)

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 8, 2022
@6543 6543 merged commit e73c5fd into go-gitea:main Mar 8, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 9, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
302fe1f 
* giteaofficial/main:
  Add button for issue deletion (go-gitea#19032)
  Fix script compatiable with OpenWrt (go-gitea#19000)
  Allow users to self-request a PR review (go-gitea#19030)
  Fix wrong scopes caused by empty scope input (go-gitea#19029)
  Feature: show issue assignee on project board (go-gitea#15232)
  bump go deps (go-gitea#19021)
  Don't show context cancelled errors in attribute reader (go-gitea#19006)
  Set `rel="nofollow noindex"` on new issue links (go-gitea#19023)
  update to correct stable version
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Mar 9, 2022 •
edited
Loading

@noerw sorry, could you help to explain shouldn't those FIXMEs be github issues? I didn't get the point ... 😂

Oh nvm, I get the point now ~~~~ I didn't create github issues because I think that the comments can be easier to be found in future by developers. Even if I created github issues, would there be some fixes soon? If no ..... the issues would be lost in the long issue history .........

@wxiaoguang wxiaoguang deleted the fix-18972 branch March 9, 2022 03:39
@wxiaoguang
Copy link
Contributor Author

The related issue is created:

@zeripath
Copy link
Contributor

Please send backport,

zeripath pushed a commit to zeripath/gitea that referenced this pull request Mar 19, 2022
@wxiaoguang @zeripath
Fix wrong scopes caused by empty scope input (go-gitea#19029)
8fcb071 
Backport go-gitea#19029
@zeripath zeripath mentioned this pull request Mar 19, 2022
Merged
@zeripath zeripath added the backport/done All backports for this PR have been created label Mar 19, 2022
wxiaoguang pushed a commit that referenced this pull request Mar 20, 2022
@zeripath
Fix wrong scopes caused by empty scope input (#19029) (#19145)
a3f3e31 
Backport #19029
Fix #18972 Gitea prepends requested openid scope with + after updating authentication source
zeripath added a commit to zeripath/gitea that referenced this pull request Mar 23, 2022
@zeripath
Changelog for 1.16.5
fb7de1c 
 ## [1.16.5](https://github.com/go-gitea/gitea/releases/tag/1.16.5) - 2022-03-23

* BREAKING
  * Bump to build with go1.18 (go-gitea#19120 et al) (go-gitea#19127)
* SECURITY
  * Prevent redirect to Host (2) (go-gitea#19175) (go-gitea#19186)
  * Try to prevent autolinking of displaynames by email readers (go-gitea#19169) (go-gitea#19183)
  * Clean paths when looking in Storage (go-gitea#19124) (go-gitea#19179)
  * Do not send notification emails to inactive users (go-gitea#19131) (go-gitea#19139)
  * Do not send activation email if manual confirm is set (go-gitea#19119) (go-gitea#19122)
* ENHANCEMENTS
  * Use the new/choose link for New Issue on project page (go-gitea#19172) (go-gitea#19176)
* BUGFIXES
  * Fix compare link in active feeds for new branch (go-gitea#19149) (go-gitea#19185)
  * Redirect .wiki/* ui link to /wiki (go-gitea#18831) (go-gitea#19184)
  * Ensure deploy keys with write access can push (go-gitea#19010) (go-gitea#19182)
  * Ensure that setting.LocalURL always has a trailing slash (go-gitea#19171) (go-gitea#19177)
  * Cleanup protected branches when deleting users & teams (go-gitea#19158) (go-gitea#19174)
  * Use IterateBufferSize whilst querying repositories during adoption check (go-gitea#19140) (go-gitea#19160)
  * Fix NPE /repos/issues/search when not signed in (go-gitea#19154) (go-gitea#19155)
  * Use custom favicon when viewing static files if it exists (go-gitea#19130) (go-gitea#19152)
  * Fix the editor height in review box (go-gitea#19003) (go-gitea#19147)
  * Ensure isSSH is set whenever DISABLE_HTTP_GIT is set (go-gitea#19028) (go-gitea#19146)
  * Fix wrong scopes caused by empty scope input (go-gitea#19029) (go-gitea#19145)
  * Make migrations SKIP_TLS_VERIFY apply to git too (go-gitea#19132) (go-gitea#19141)
  * Handle email address not exist (go-gitea#19089) (go-gitea#19121)
* MISC
  * Update json-iterator to allow compilation with go1.18 (go-gitea#18644) (go-gitea#19100)
  * Update golang.org/x/crypto (go-gitea#19097) (go-gitea#19098)

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this pull request Mar 23, 2022
Merged
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@wxiaoguang
Fix wrong scopes caused by empty scope input (go-gitea#19029)
cc12d3b
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@noerw noerw noerw approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

Gitea prepends requested openid scope with + after updating authentication source
5 participants
@wxiaoguang @zeripath @noerw @6543 @GiteaBot