Set uploadpack.allowFilter etc on gitea serv to enable partial clones with SSH #20879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with ssh When setting.Git.DisablePartialClone is set to false then the web server will add filter support to web http. The ssh serv wrapper is missing this code and therefore we need to add it. Fix go-gitea#20400 Signed-off-by: Andrew Thornton <art27@cantab.net>
delvh
approved these changes
Aug 20, 2022
GiteaBot
added
the
lgtm/need 1
Gusted
reviewed
Aug 21, 2022
| @@ -326,6 +326,11 @@ func runServ(c *cli.Context) error { | |||
| // it could be re-considered whether to use the same git.CommonGitCmdEnvs() as "git" command later. | |||
| gitcmd.Env = append(gitcmd.Env, git.CommonCmdServEnvs()...) | |||
|
|
|||
| // By default partial clones are disabled, enable them from git v2.22 | |||
| if !setting.Git.DisablePartialClone && git.CheckGitVersionAtLeast("2.22") == nil { | |||
| gitcmd.Env = append(gitcmd.Env, "-c", "uploadpack.allowfilter=true", "-c", "uploadpack.allowAnySHA1InWant=true") | |||
There was a problem hiding this comment.
I don't think these works if you append them to the environment variables. You need to pass these as arguments.
There was a problem hiding this comment.
hah! What was I thinking! Of course this should be arguments!!
|
I'm gonna close this as we need to decide what we're going to do here - but we should do something about this. |
zeripath
added
type/bug
backport/v1.17
and removed
type/bug
lgtm/need 1
|
Ready again |
GiteaBot
added
the
lgtm/need 1
zeripath
removed
type/bug
lgtm/need 1
|
but I can't reopen the request for some reason so see #20902 |
GiteaBot
added
the
lgtm/need 1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting.Git.DisablePartialClone is set to false then the
web server will add filter support to web http. The ssh serv
wrapper is missing this code and therefore we need to add it.
Fix #20400
Signed-off-by: Andrew Thornton art27@cantab.net