Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant checking DisableDownloadSourceArchives #20997

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Remove redundant checking DisableDownloadSourceArchives #20997

merged 1 commit into from
Aug 30, 2022

Conversation

wolfogre
Copy link
Member 

{{if not .DisableDownloadSourceArchives}}
   ...
  {{if not $.DisableDownloadSourceArchives}}
  ...

It may be caused by an accidental merging, see #20719.

The main branch is fine.

@wolfogre wolfogre changed the title Remove redundant DisableDownloadSourceArchives Remove redundant checking DisableDownloadSourceArchives Aug 30, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 30, 2022
silverwind
silverwind approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yes appears to be an error in the backport.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 30, 2022
@jolheiser jolheiser merged commit 2e2133d into go-gitea:release/v1.17 Aug 30, 2022
@jolheiser jolheiser added this to the 1.17.2 milestone Aug 30, 2022
@jolheiser jolheiser added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Aug 30, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.17.2
Development

Successfully merging this pull request may close these issues.
5 participants
@wolfogre @lunny @silverwind @GiteaBot @jolheiser