Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty container layer history and UI #21251

Merged
merged 6 commits into from
Sep 27, 2022
Merged

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Sep 23, 2022

Fixes #21248

before
grafik

after
grafik

@siarie
Copy link

siarie commented Sep 25, 2022

I think this can be solved with adding word-break: break-word; to the td element. however the key column may wrapped as well. This can be solved by adding fixed size to the key column.

Another solution is to wrap the value inside the pre tag. here the example:

<!-- CSS -->
<style>
.ui.table td pre {
  white-space: pre-wrap;
  word-break: break-word;
}
</style>

<!-- HTML -->
<table>
  ...
  <tbody>
    <tr>
      <td>the.key</td>
      <td><pre>the value here</pre></td>
    </tr>
  </tbody>
</table>

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 25, 2022
@silverwind
Copy link
Member

silverwind commented Sep 25, 2022

Table overflow has it's own weird rules that generally don't follow what other HTML elements do. table-layout: fixed would achieve wrapping but has unknown side-effects and the page gets pretty long with with all that JSON.

Maybe it's also good to wrap the JSON into a <pre><code>.

@silverwind
Copy link
Member

silverwind commented Sep 25, 2022

You can add the fixed class to table to fix it. It makes both columns 50% width which is often too wide for the first column, but I can't really find another way to fix this, besides swapping table for flexbox which could do what we want.

@KN4CK3R KN4CK3R marked this pull request as ready for review September 26, 2022 11:39
@KN4CK3R KN4CK3R added the topic/ui Change the appearance of the Gitea UI label Sep 26, 2022
@lafriks
Copy link
Member

lafriks commented Sep 26, 2022

Would be nice if key would be vertically aligned to top

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 26, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 27, 2022
@6543 6543 merged commit 904b324 into go-gitea:main Sep 27, 2022
@KN4CK3R KN4CK3R deleted the fix-21248 branch September 27, 2022 13:58
KN4CK3R added a commit to KN4CK3R/gitea that referenced this pull request Sep 27, 2022
lunny pushed a commit that referenced this pull request Sep 27, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 28, 2022
* upstream/main:
  Update bluemonday (go-gitea#21281)
  Add support for authentication based on reverse proxy email (go-gitea#19949)
  Do not allow organisation owners add themselves as collaborator (go-gitea#20043)
  Feature: Case-insensitive "find files in repo" (go-gitea#21269)
  Better repo API unit checks (go-gitea#21130)
  Fix empty container layer history and UI (go-gitea#21251)
  Add filetree on left of diff view (go-gitea#21012)
@6543 6543 added the backport/done All backports for this PR have been created label Oct 15, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/packages topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table UI is overflow when package label is too long
6 participants