Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that Webhook tasks are not double delivered #21558

Merged
merged 19 commits into from
Nov 23, 2022
Merged

Ensure that Webhook tasks are not double delivered #21558

merged 19 commits into from
Nov 23, 2022

Commits on Oct 23, 2022

  1. Ensure that Webhook tasks are not double delivered 

    When re-retrieving hook tasks from the DB double check if they have not been delivered
in the meantime. Further ensure that tasks are marked as delivered when they are being
delivered.

In addition improve the error reporting and make sure that the webhook task population
script runs in a separate goroutine.

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    f964274 View commit details
    Browse the repository at this point in the history

  2. Update models/webhook/hooktask.go

    @zeripath
    zeripath committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    790ecde View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Update services/webhook/deliver.go 

    Co-authored-by: delvh <dev.lh@web.de>
    @zeripath @delvh
    zeripath and delvh committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    88cc381 View commit details
    Browse the repository at this point in the history

  2. Update services/webhook/deliver.go

    @zeripath
    zeripath committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    57f13c1 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into slight-fix-hook-delivery

    @zeripath
    zeripath committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    5267a15 View commit details
    Browse the repository at this point in the history

  4. Actually we need to check before the defer is in action! 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    6225c5d View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. Merge branch 'main' into slight-fix-hook-delivery

    @lunny
    lunny committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    c830c79 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into slight-fix-hook-delivery

    @lunny
    lunny committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    be23648 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2022

  1. Merge branch 'main' into slight-fix-hook-delivery

    @zeripath
    zeripath committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    4982907 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2022

  1. Merge branch 'main' into slight-fix-hook-delivery

    @zeripath
    zeripath committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    0cd4215 View commit details
    Browse the repository at this point in the history

  2. remove unnecessary SetExpr 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    0e82d12 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. fix test 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    cc86689 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into slight-fix-hook-delivery

    @zeripath
    zeripath committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    0413d73 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2022

  1. Merge branch 'main' into slight-fix-hook-delivery

    @lunny
    lunny committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    4b1351d View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2022

  1. Merge branch 'main' into slight-fix-hook-delivery

    @lunny
    lunny committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    877d101 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into slight-fix-hook-delivery

    @lunny
    lunny committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    8dbfd89 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. Merge branch 'main' into slight-fix-hook-delivery

    @lunny
    lunny committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    165d18c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into slight-fix-hook-delivery

    @lunny
    lunny committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    91ad108 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into slight-fix-hook-delivery

    @lunny
    lunny committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    fa0bba0 View commit details
    Browse the repository at this point in the history